On 3/17/10 13:12, Guillaume Nodet wrote:
Yeah, what I mean is that we have a lot of different models to represent the
same data.
* the one in bundlerepository
* the one included in the maven-bundle-plugin with the bindex code
* another one from the maven-bundle-plugin inherited from the
obr-maven-plugin
Those three models are slightly different but really represent the same
data, so I'm planning to enhance the one from bundlerepository to support
all the use cases.
In addition, i'll extract some bits (header parser, version range, etc...)
in a util subproject which can be reused (simply by embedding the classes
for now) in the other subprojects.
Ok.
-> richard
On Wed, Mar 17, 2010 at 20:23, Richard S. Hall<[email protected]> wrote:
On 3/17/10 12:21, Guillaume Nodet wrote:
One thing I'm struggling with is the number of other projects included in
the maven-bundle-plugin.
It seems we include the whole bindex code, obr plugins, some maven bits.
There are a lot of duplication here.
For bindex, why do we include it ? It is mostly redundant with the
bundlerepository.
We don't include bindex in OBR, so I am not sure how that is redundant. I
believe bindex is included in maven-bundle-plugin because it needs to
generate repository.xml files from the generated bundle files.
-> richard
I think I'm going to refactor the whole thing unless there is something
obvious I'm missing here.
On Wed, Mar 17, 2010 at 10:32, Guillaume Nodet<[email protected]> wrote:
Both bundlerepository and maven-bundle-plugin contain similar code
like the RepositoryImpl, BundleInfo (quite similar to the
LocalResourceImpl from bundlerepository), repository xml parser,
etc...
I think it would make more sense to enhance the ones in
bundlerepostiory and reuse those from the maven-bundle-plugin rather
than keep the duplication.
Thoughts ?
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
