I think you're proposal needs to be discussed more, as it would break a whole new feature (transformation of jars into osgi bundles) which is very important since 2.0. So i'll keep this vote open and we should continue discussing this issue on the appropriate jira.
Here's my +1 On Fri, Apr 30, 2010 at 15:27, Guillaume Nodet <[email protected]> wrote: > Right, I suppose checking Bundle-SymbolicName should be sufficient. > Could you please raise a JIRA, i'll try to upload a new version asap. > > > On Fri, Apr 30, 2010 at 15:18, Sahoo <[email protected]> wrote: > >> -1 (non binding) >> >> During testing I found a new issue; it is not a regression. FileInstall >> does not recognize jar files that have only Bundle-SymbolicName. I see the >> following code in BundleTransformer.java: >> >> if (m.getMainAttributes().getValue(new >> Attributes.Name("Bundle-SymbolicName")) != null >> && m.getMainAttributes().getValue(new >> Attributes.Name("Bundle-Version")) != null) >> >> Why is this the case? Earlier fileinstall used to be able install anything >> that's a jar file. >> >> Thanks, >> Sahoo >> >> Guillaume Nodet wrote: >> >>> I would like to call a vote on the following subproject releases: >>> >>> fileinstall 3.0.0 >>> >>> Staging repository: >>> https://repository.apache.org/content/repositories/orgapachefelix-035/< >>> https://repository.apache.org/content/repositories/orgapachefelix-034/> >>> >>> >>> You can use this UNIX script to download the release and verify the >>> signatures: >>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh >>> >>> Usage: >>> sh check_staged_release.sh 035 /tmp/felix-staging >>> >>> Please vote to approve this release: >>> >>> [ ] +1 Approve the release >>> [ ] -1 Veto the release (please provide specific comments) >>> >>> >>> >> > > > -- > Cheers, > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > Open Source SOA > http://fusesource.com > > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
