[
https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863132#action_12863132
]
Jamie goodyear commented on FELIX-2280:
---------------------------------------
Many thanks for the patch, I was able to apply it to my local svn checkout :)
I'll take a look through the changes and get back to you soon, obviously with a
variety of databases a good bit of testing is required (especially around
Oracle and its long living lock behaviors).
The issue of including the jdbc url option for creating a database, we can
experiment with the option where the backend database supports it (striving for
ease of use is good in my humble opinion).
I'm ok with separating Derby out from the generic DefaultJDBCLock, long as we
can fall back to Derby via the Default -- I'd like to avoid having current
users need to reconfigure their lock settings.
As to the other databases you've mentioned please feel free to submit a feature
request and patch for any/all you feel like contributing.
> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
> -----------------------------------------------------------------------------
>
> Key: FELIX-2280
> URL: https://issues.apache.org/jira/browse/FELIX-2280
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Affects Versions: karaf-1.4.0
> Environment: All
> Reporter: Christian Müller
> Attachments: FELIX-2280.patch, FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock,
> org.apache.felix.karaf.main.MySQLJDBCLock and
> org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I
> propose a solution like in ActiveMQ [package
> org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provide a
> patch for it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
