[
https://issues.apache.org/jira/browse/FELIX-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Felix Meschberger resolved FELIX-2635.
--------------------------------------
Fix Version/s: webconsole-3.1.4
Resolution: Fixed
Good catch ! Thanks for providing the patch.
I have applied it in Rev. 1002635 with a minor modification: Instead of
assigning the parameter value "null" is assigned to make the intent clear and
added try-catch around the destroy calls.
> PluginHolder.setServletContext() must nullify servlet context after plugins
> destroying
> ---------------------------------------------------------------------------------------
>
> Key: FELIX-2635
> URL: https://issues.apache.org/jira/browse/FELIX-2635
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.4
> Reporter: Victor Antonovich
> Assignee: Felix Meschberger
> Fix For: webconsole-3.1.4
>
> Attachments: webconsole_set_servlet_context.patch
>
>
> Java Servlet Specification Version 2.5, SRV.15.2.12.1 says: "All servlets and
> filters have been destroy()ed before any ServletContextListeners are notified
> of context destruction". But current PluginHolder.setServletContext()
> implementation calls destroy() method of plugins after destroying
> (nullifying) of ServletContext. This causes NPE in plugins trying to access
> to ServletContext in their destroy() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
