[
https://issues.apache.org/jira/browse/FELIX-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919256#action_12919256
]
Felix Meschberger commented on FELIX-2644:
------------------------------------------
Yes, this is caused by my refactoring of the OSGiManager setup.
Maybe we should enhance the PluginHolder and its internal classes
Plugin/ServletPlugin addding an "enabled" flag and changing the getPlugins()
and getPlugin(String) method to respect this enabled flag.
WDYT ?
> cannot disable plugin
> ---------------------
>
> Key: FELIX-2644
> URL: https://issues.apache.org/jira/browse/FELIX-2644
> Project: Felix
> Issue Type: Bug
> Components: Web Console
> Affects Versions: webconsole-3.1.2
> Reporter: Valentin Valchev
>
> Something went terribly wrong! I cannot disable a plugin from the
> configuration.
> The reason for this is that the plugins are initialized during startup. In
> the constructor, the Web Console will lookup the configuration and see if
> plugin is disable. If so, it will be ignored, otherwise the plugin will be
> instantiated and ready to use.
> However, configuration delivery is asynchronous, so you don't know when the
> configuration dictionary is delivered and in my case, it is 'updated' a
> little bit after the initialization. So initially, when the web console is
> initialized, it has 'null' - default configuration and all plugins are
> enabled. Then later on, after updating the configuration I disable as example
> the 'shell' plugin.
> Unfortunately, the web console will not check if the plugin is disabled, when
> the browser is opened and the 'shell' plugin remains visible.
> Putting the plugin initialization in the constructor, means, that there is no
> way to actually disable a plugin and all internal plugin will be instantiate
> and visible by default, Even if they are not needed, there is no browser
> request for them or disabled by the configuration.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
