[ 
https://issues.apache.org/jira/browse/FELIX-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923180#action_12923180
 ] 

Felix Meschberger commented on FELIX-2671:
------------------------------------------

95 [RFC 160/Coordinator Service] Reentrant Participant 
Participants cannot be reentrant any longer. Nothing to do in our 
implementation, I already assumed this.

96 [RFC 160/Coordinator Service] Coordination Nesting
Timedout Coordinations up in the Stack are effectively terminated and removed 
from the stack. Our implementation already does this; nothing more to do.

97 [RFC 160/Coordinator Service] Clarification on Coordination.end
On timeout there is no interrupt/delay any more but the Coordination should 
immediately be terminiated (Rev. 1025761)

98 [RFC 160/Coordinator Service] Undocumented Coordination.getVariable method 
There will be updates in a future draft. Nothing to do for us right now

100 [RFC 160/Coordinator Service] Undocumented Coordinator.isActive method 
Added the isTerminated method in the interface and implementation (Rev. 1025759)

101 [RFC 160/Coordinator Service] Wrong value for TIMEOUT constant
Fixed in the spec. Nothing to do for use, we already are correct

102 [RFC 160/Coordinator Service] Wrong type for COORDINATIONS_TYPE constant
Fixed in the spec. Nothing to do for use, we already are correct

103 [RFC 160/Coordinator Service] JavaDoc of Coordination.end()
JavaDoc is updated. For now I assume our implementation is correct and will be 
reflected by the new JavaDoc

104 [RFC 160/Coordinator Service] Coordinator Life Cycle
Coordinations must be terminated if the service is ungotten as confirmed by 
Peter Kriens. This functionality requires some level of refactoring to be able 
to terminate the correct Coordinations. For now added a TODO comment in Rev. 
1025764.

105 [RFC 160/Coordinator Service] Missing CoordinationException on 
Coordinator.participateOrBegin 
The participateOrBegin method is removed (Rev. 1025763)

Remaining issues:
 * OSGi Bug 99 has not been commented yet
 * Need to terminiate Coordinations for ungotten services

> Apply changes from feedback to Coordinator Service draft (RFC160)
> -----------------------------------------------------------------
>
>                 Key: FELIX-2671
>                 URL: https://issues.apache.org/jira/browse/FELIX-2671
>             Project: Felix
>          Issue Type: Task
>          Components: Coordinator Service, Specification compliance
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>
> After a first implementation and reading the draft 3 spec I have reported a 
> number of bugs with the OSGi bug database:
> 95  [RFC 160/Coordinator Service] Reentrant Participant
> 96  [RFC 160/Coordinator Service] Coordination Nesting
> 97  [RFC 160/Coordinator Service] Clarification on Coordination.end
> 98  [RFC 160/Coordinator Service] Undocumented Coordination.getVariable 
> method 
> 99  [RFC 160/Coordinator Service] Forcing Coordination active on a single 
> thread
> 100 [RFC 160/Coordinator Service] Undocumented Coordinator.isActive method
> 101 [RFC 160/Coordinator Service] Wrong value for TIMEOUT constant
> 102 [RFC 160/Coordinator Service] Wrong type for COORDINATIONS_TYPE constant
> 103 [RFC 160/Coordinator Service] JavaDoc of Coordination.end()
> 104 [RFC 160/Coordinator Service] Coordinator Life Cycle
> 105 [RFC 160/Coordinator Service] Missing CoordinationException on 
> Coordinator.participateOrBegin
> This issue is to track required changes as a consequence of the resolution 
> these bugs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to