[ 
https://issues.apache.org/jira/browse/FELIX-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephane Chomat updated FELIX-2921:
-----------------------------------

    Description: 
The properties like FRAMEWORK_SYSTEMPACKAGES are bad substituted by the method 
Util.getDefaultProperty.
The properties dollar is missing and the value is '' returned by 
System.getProperty.


The bad default value for FRAMEWORK_SYSTEMPACKAGES  is 

org.osgi.framework; version=1.5.0, org.osgi.framework.launch; version=1.0.0, 
org.osgi.framework.hooks.service; version=1.0.0, org.osgi.service.packageadmin; 
version=1.2.0, org.osgi.service.startlevel; version=1.1.0, 
org.osgi.service.url; version=1.0.0, org.osgi.util.tracker; version=1.4.0 
{jre-{java.specification.version}}


You can add this test :

    public void testDefaultProperty() {
       Logger logger = new Logger();
       
       String jsv = System.getProperty("java.specification.version");
       String jre = Util.getDefaultProperty(logger, "jre-"+jsv);
        
       String actual = Util.getDefaultProperty(logger, 
Constants.FRAMEWORK_SYSTEMPACKAGES);
       
       assertEquals("org.osgi.framework; version=1.5.0, 
org.osgi.framework.launch; version=1.0.0, org.osgi.framework.hooks.service; 
version=1.0.0, org.osgi.service.packageadmin; version=1.2.0, 
org.osgi.service.startlevel; version=1.1.0, org.osgi.service.url; 
version=1.0.0, org.osgi.util.tracker; version=1.4.0 "+jre, actual);
    }

If you add this line before test, the test works
     System.setProperty("dollar","$");




  was:
The properties like FRAMEWORK_SYSTEMPACKAGES are bad substituted by the method 
Util.getDefaultProperty.
The properties dollar is missing and the value is '' returned by 
System.getProperty.


The bad default value for FRAMEWORK_SYSTEMPACKAGES  is 

org.osgi.framework; version=1.5.0, org.osgi.framework.launch; version=1.0.0, 
org.osgi.framework.hooks.service; version=1.0.0, org.osgi.service.packageadmin; 
version=1.2.0, org.osgi.service.startlevel; version=1.1.0, 
org.osgi.service.url; version=1.0.0, org.osgi.util.tracker; version=1.4.0 
{jre-{java.specification.version}}


You can add this test :

    public void testDefaultProperty() {
       Logger logger = new Logger();
       
       String jsv = System.getProperty("java.specification.version");
       String jre = Util.getDefaultProperty(logger, "jre-"+jsv);
        
       String actual = Util.getDefaultProperty(logger, 
Constants.FRAMEWORK_SYSTEMPACKAGES);
       
       assertEquals("org.osgi.framework; version=1.5.0, 
org.osgi.framework.launch; version=1.0.0, org.osgi.framework.hooks.service; 
version=1.0.0, org.osgi.service.packageadmin; version=1.2.0, 
org.osgi.service.startlevel; version=1.1.0, org.osgi.service.url; 
version=1.0.0, org.osgi.util.tracker; version=1.4.0 "+jre, actual);
       String dollar = Util.getDefaultProperty(logger, "dollar");
       assertEquals("$", dollar);
    }




> Util.getDefaultProperty return bad values
> -----------------------------------------
>
>                 Key: FELIX-2921
>                 URL: https://issues.apache.org/jira/browse/FELIX-2921
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: framework-3.2.0
>         Environment: apple
>            Reporter: Stephane Chomat
>             Fix For: framework-4.0.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The properties like FRAMEWORK_SYSTEMPACKAGES are bad substituted by the 
> method Util.getDefaultProperty.
> The properties dollar is missing and the value is '' returned by 
> System.getProperty.
> The bad default value for FRAMEWORK_SYSTEMPACKAGES  is 
> org.osgi.framework; version=1.5.0, org.osgi.framework.launch; version=1.0.0, 
> org.osgi.framework.hooks.service; version=1.0.0, 
> org.osgi.service.packageadmin; version=1.2.0, org.osgi.service.startlevel; 
> version=1.1.0, org.osgi.service.url; version=1.0.0, org.osgi.util.tracker; 
> version=1.4.0 {jre-{java.specification.version}}
> You can add this test :
>     public void testDefaultProperty() {
>        Logger logger = new Logger();
>        
>        String jsv = System.getProperty("java.specification.version");
>        String jre = Util.getDefaultProperty(logger, "jre-"+jsv);
>         
>        String actual = Util.getDefaultProperty(logger, 
> Constants.FRAMEWORK_SYSTEMPACKAGES);
>        
>        assertEquals("org.osgi.framework; version=1.5.0, 
> org.osgi.framework.launch; version=1.0.0, org.osgi.framework.hooks.service; 
> version=1.0.0, org.osgi.service.packageadmin; version=1.2.0, 
> org.osgi.service.startlevel; version=1.1.0, org.osgi.service.url; 
> version=1.0.0, org.osgi.util.tracker; version=1.4.0 "+jre, actual);
>     }
> If you add this line before test, the test works
>      System.setProperty("dollar","$");

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to