Well, does it actually cause any problem to you ?  I've asked more than once
but had no answer.
Because removing those headers actually cause problems to me.

Fwiw, the discussions we had in the felix community lead that those headers
were acceptable.
Maybe we can revisit and find a better way with the new OBR spec provided
that those constraints can be captured.

On Tue, Sep 20, 2011 at 11:14, Alasdair Nottingham <[email protected]> wrote:

> Hi,
>
> As I have said many times in the past it is not valid to put attributes
> into
> an Import-Service header. The OSGi Alliance specification that defines the
> syntax says it is a comma separated list of service interface/class names.
> I
> support any effort that reduces the use of invalid OSGi header syntax.
>
> Alasdair
>
> On 20 September 2011 08:12, Guillaume Nodet <[email protected]> wrote:
>
> > Unless I hear something, I plan to revert this change.
> >
> > On Thu, Sep 8, 2011 at 15:42, Guillaume Nodet <[email protected]> wrote:
> >
> > > What is the reason for removing those informations ?
> > > Those are used when computing the obr constraints ... and actually
> > > used when resolving using OBR.
> > >
> > > On Thu, Jul 28, 2011 at 10:48,  <[email protected]> wrote:
> > > > Author: cziegeler
> > > > Date: Thu Jul 28 08:48:27 2011
> > > > New Revision: 1151765
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=1151765&view=rev
> > > > Log:
> > > > FELIX-2156 - Remove Import-Service header in MANIFEST
> > > >
> > > > Modified:
> > > >    felix/trunk/eventadmin/impl/changelog.txt
> > > >    felix/trunk/eventadmin/impl/pom.xml
> > > >
> > > > Modified: felix/trunk/eventadmin/impl/changelog.txt
> > > > URL:
> > >
> >
> http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/changelog.txt?rev=1151765&r1=1151764&r2=1151765&view=diff
> > > >
> > >
> >
> ==============================================================================
> > > > --- felix/trunk/eventadmin/impl/changelog.txt (original)
> > > > +++ felix/trunk/eventadmin/impl/changelog.txt Thu Jul 28 08:48:27
> 2011
> > > > @@ -7,6 +7,9 @@ Changes from 1.2.12 to 1.2.14
> > > >     * [FELIX-3053] - Potential deadlock if event handler throws
> > Throwable
> > > and is bypassing timeout handling
> > > >     * [FELIX-3055] - Event Admin deadlocks when sendEvent is called
> > from
> > > within a handleEvent method
> > > >
> > > > +** Improvement
> > > > +    * [FELIX-2156] - Remove Import-Service header in MANIFEST
> > > > +
> > > >
> > > >  Changes from 1.2.10 to 1.2.12
> > > >  -----------------------------
> > > >
> > > > Modified: felix/trunk/eventadmin/impl/pom.xml
> > > > URL:
> > >
> >
> http://svn.apache.org/viewvc/felix/trunk/eventadmin/impl/pom.xml?rev=1151765&r1=1151764&r2=1151765&view=diff
> > > >
> > >
> >
> ==============================================================================
> > > > --- felix/trunk/eventadmin/impl/pom.xml (original)
> > > > +++ felix/trunk/eventadmin/impl/pom.xml Thu Jul 28 08:48:27 2011
> > > > @@ -98,14 +98,6 @@
> > > >                         </Import-Package>
> > > >
> > > <Export-Package>org.osgi.service.event</Export-Package>
> > > >
> > > <Private-Package>org.apache.felix.eventadmin.impl.*</Private-Package>
> > > > -                        <Import-Service>
> > > > -
> > >
> >
>  org.osgi.service.event.EventHandler;availability:=optional;multiple:=true,
> > > > -
> > >
>  org.osgi.service.log.LogService;availability:=optional;multiple:=false,
> > > > -
> > >
> >
>  org.osgi.service.log.LogReaderService;availability:=optional;multiple:=false
> > > > -                        </Import-Service>
> > > > -                        <Export-Service>
> > > > -                           org.osgi.service.event.EventAdmin
> > > > -                        </Export-Service>
> > > >                         <!-- Include concurrent lib but not sub
> > packages
> > > -->
> > > >                         <Embed-Dependency>
> > > >
> > > concurrent;inline="EDU/oswego/cs/dl/util/concurrent/[A-Z]*"
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> > > ------------------------
> > > Guillaume Nodet
> > > ------------------------
> > > Blog: http://gnodet.blogspot.com/
> > > ------------------------
> > > Open Source SOA
> > > http://fusesource.com
> > >
> >
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> > ------------------------
> > Blog: http://gnodet.blogspot.com/
> > ------------------------
> > Open Source SOA
> > http://fusesource.com
> >
>
>
>
> --
> Alasdair Nottingham
> [email protected]
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com

Reply via email to