[ 
https://issues.apache.org/jira/browse/FELIX-3102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113350#comment-13113350
 ] 

Felix Meschberger commented on FELIX-3102:
------------------------------------------

Thanks for reporting. I agree with your assessment of this being a blocker.

> Cleanup dependencies of org.apache.felix.http.cometd
> ----------------------------------------------------
>
>                 Key: FELIX-3102
>                 URL: https://issues.apache.org/jira/browse/FELIX-3102
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-2.2.0
>            Reporter: Julian Sedding
>            Assignee: Felix Meschberger
>            Priority: Blocker
>             Fix For: http-2.2.2
>
>         Attachments: FELIX-3102.patch
>
>
> The cometd implementation from FELIX-1796 has several issues regarding the 
> dependencies.
> 1. It inroduces a cyclic dependency between org.apache.felix.http.cometd and 
> org.apache.felix.http.api. API imports org.cometd,which is exported by 
> o.a.f.h.cometd and o.a.f.h.cometd imports o.a.f.h.api. The dependency on 
> o.a.f.h.api is merely present because the CometdService interface has been 
> added. I propose to move the CometdService interface into o.a.f.h.cometd 
> instead. 
> This is an API change, however the HTTP API bundle with CometdService has not 
> been released yet, afaik, so this should not be an issue.
> 2. The cometd bundle's Export-Package directive looks as follows
>     org.apache.felix.http.api;version=${pom.version},
>     org.cometd;version=1.0.beta7,
>     org.mortbay.*;-split-package:=merge-first,
>     org.osgi.service.http,
>     javax.servlet.*;version=2.5;-split-package:=merge-first
> It should only export "org.cometd;version=1.0.beta7", as the org.mortbay 
> package is an implementation detail and the other three packages should be 
> provided by other bundles.
> The attached patch fixes this, and cleans up the dependencies section.
> A nice side-effect of these changes is that the cometd bundle can just be 
> deployed as-is even with older versions of HTTP Service.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to