Hi, On Tue, Jan 10, 2012 at 11:20 PM, Felix Meschberger <[email protected]> wrote: > Hi, > > Am 11.01.2012 um 08:08 schrieb Marcel Offermans: > >> Felix, out of interest, does this plugin know about the OSGi execution >> environments and the exact set of methods it allows (which is not the same >> as the Java 1.3 API)? > > No, it does not know about the OSGi definitions. They created signature files > from the actual JDK contents.
In theory, you can generate new Animal Sniffer signatures: http://mojo.codehaus.org/animal-sniffer-maven-plugin/examples/generating-other-api-signatures.html Justin > > While it -- unfortunately -- proves to not be 100% safe (some API is not > flagged, which should be and some calls cannot be properly flagged at all, > and of course Reflection us is not handled), it gives a good head start. You > might argue that you get a false sense of certainty. I agree, but can live > with this in this context ;-) > > Regards > Felix > >> >> Greetings, Marcel >> >> >> On Jan 11, 2012, at 8:02 AM, Felix Meschberger wrote: >> >>> Hi Ken, >>> >>> Am 11.01.2012 um 00:20 schrieb Ken Gilmer: >>> >>>> Hi Felix, >>>> >>>> That's a great idea, thanks! I updated (revision 1229793) the root >>>> httplite POM to include the Animal Sniffer plugin and it seems to be >>>> working. I cannot be certain, but maven downloads Animal Sniffer artifacts >>>> and I get more build output. I do not see a definitive "source valid" >>>> message from the plugin but assume that since the build is successful that >>>> the plugin didn't find any invalid source. >>> >>> Yes, the build output indicates the plugin is running. And if all goes well >>> -- similar to the SecurityManager checks -- nothing really happens. If >>> there is "invalid" API, the plugin aborts the build with an error messages. >>> >>> Regards >>> Felix >>> >>>> >>>> cheers >>>> ken >>>> >>>> On Wed, Jan 11, 2012 at 1:07 AM, Carsten Ziegeler >>>> <[email protected]>wrote: >>>> >>>>> +1 >>>>> >>>>> Carsten >>>>> >>>>> 2012/1/9 Felix Meschberger <[email protected]>: >>>>>> Hi, >>>>>> >>>>>> We currently try to be strictly Java 1.3 by setting compiler source and >>>>> target to 1.3 in the parent POM. >>>>>> >>>>>> How about adding the Codehaus Animal Sniffer plugin configured to ensure >>>>> Java 1.3 API use ? >>>>>> >>>>>> (The WebConsole has the animal sniffer plugin configured for Java 1.4 >>>>> because we use regular expressions and some other Java 1.4 API) >>>>>> >>>>>> Regards >>>>>> Felix >>>>>> >>>>>> >>>>>> Am 08.01.2012 um 06:01 schrieb Ken Gilmer (Resolved) (JIRA): >>>>>> >>>>>>> >>>>>>> [ >>>>> https://issues.apache.org/jira/browse/FELIX-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel] >>>>>>> >>>>>>> Ken Gilmer resolved FELIX-3287. >>>>>>> ------------------------------- >>>>>>> >>>>>>> Resolution: Fixed >>>>>>> >>>>>>> All known non-Java-1.3-compatible code has been updated. >>>>>>> >>>>>>>> Light HTTP Service Java 1.3 >>>>>>>> --------------------------- >>>>>>>> >>>>>>>> Key: FELIX-3287 >>>>>>>> URL: https://issues.apache.org/jira/browse/FELIX-3287 >>>>>>>> Project: Felix >>>>>>>> Issue Type: Improvement >>>>>>>> Components: Lightweight HTTP Service >>>>>>>> Reporter: Yann Diorcet >>>>>>>> Assignee: Ken Gilmer >>>>>>>> Attachments: patch1.patch >>>>>>>> >>>>>>>> >>>>>>>> Almost all the code is compatible with Java 1.3 except >>>>> ServletPrintWriter (Charset stuff). >>>>>>>> Is it possible to make the code compatible with CDC >>>>> (minimum/foundation)? >>>>>>> >>>>>>> -- >>>>>>> This message is automatically generated by JIRA. >>>>>>> If you think it was sent incorrectly, please contact your JIRA >>>>> administrators: >>>>> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa >>>>>>> For more information on JIRA, see: >>>>> http://www.atlassian.com/software/jira >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Carsten Ziegeler >>>>> [email protected] >>>>> >>> >>> >>> >>> >> >
