On 1 Feb 2012, at 10:24, Arjun Panday <[email protected]> wrote:
> On 01/31/2012 11:26 PM, Stuart McCulloch wrote: >> On 31 Jan 2012, at 22:06, Richard S. Hall wrote: >> >>> +1 >>> >>> The NOTICE file is a little messed up in the plugin, it seems to repeat >>> itself. The copyright year should be updated to 2012 in both NOTICE and >>> DEPENDENCIES. >>> >>> -> richard >>> >>> p.s. That's a really big bundle...8.5MB... :-) >> To be fair ~8mb of that is the Scala runtime... maybe that should be >> separated into its own bundle in case others want to re-use it? > > Exactly, plus a bit of javascript libraries.. the plugin itself is quite > small. > > Unfortunately the scala runtime doesn't come readily packaged as an OSGi > bundle. > The original project didn't embed the scala runtime; it came with a readme > file to explain how to wrap the scala library using bnd. But for the release, > in order to have something readily useable, I decided to embed the scala > library. > > It's a packaging issue. > I wouldn't mind creating a new module just for the scala library, outside the > service diagnostics sub-project, so that other sub-projects can use scala. > > I think I'll go ahead with this release for now and maybe I can issue a new > JIRA for the scala library packaging? Sounds good to me, definitely go ahead with this release - it was just a thought for future development. > thanks, > -arjun > >> >>> On 1/20/12 03:59 , Arjun Panday wrote: >>>> Hi everyone, >>>> >>>> Second attempt at releasing the Service Diagnostics WebConsole Plugin. >>>> I've simply refactored the POMs by moving the parent role out of the >>>> reactor POM. The directory structure seems cleaner. Let me know. >>>> >>>> Here's the staging repository: >>>> https://repository.apache.org/content/repositories/orgapachefelix-110/ >>>> >>>> >>>> You can use this UNIX script to download the release and verify the >>>> signatures: >>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh >>>> >>>> Usage: >>>> sh check_staged_release.sh 010 /tmp/felix-staging >>>> >>>> Please vote to approve this release: >>>> >>>> [ ] +1 Approve the release >>>> [ ] -1 Veto the release (please provide specific comments) >>>> >>>> This vote will be open for 72 hours. >>>> >>>> Thanks, >>>> -arjun >>>> >>>> >>>> >>>> >>>> >
