Hi, Am 11.02.2012 um 20:40 schrieb Richard S. Hall:
> Felix, > > I think the FELIX-3340 certainly seems simple enough. ok > > As for FELIX-3341, it isn't too complex either, although I'm not > familiar enough with the Gogo shell details to say whether or not this > is the best approach for a history command, but it doesn't seem too > invasive, so it would be easy to replace if a better approach is > discovered later. > > I don't know if it makes a difference, but your patch to Console.java > uses System.out.println() while existing code uses the member variable > out.println() instead. Will do (missed that member variable) > > I'd also change the formatting to match the recommended style, since I > believe it is used throughout the rest of the Gogo code. Sure. Regards Felix > > -> richard > > On 2/7/12 02:54 , Felix Meschberger wrote: >> Hi all, >> >> I created two extensions to the Felix Gogo Shell (FELIX-3340, FELIX-3341). >> >> Are there any concerns to my just applying the patches ? >> >> Regards >> Felix
