Thank you for raising the issues and providing patches.
Could you attach the patches to the related Jiras and set the ASL
license grant? Generally most projects like to keep there patches with
their related Jiras for book keeping (makes it easier to find said
patches than searching email threads if we had to go back looking for
them).
Thanks again :)
Cheers,
Jamie
On Sun, Mar 11, 2012 at 2:34 PM, Albert Devs <albert.d...@gmail.com> wrote:
> Hello,
>
> I've been using Karaf in a development setup for it's hot deployment.
> During my coding, I noticed a few annoyances in the File Install
> component and set out to fix those.
>
>
> I've attached a patch ("fileinstall-lognstartlvl.patch") which changes
> the following things:
>
> - By default, the component produces no log output. I would expect
> that errors are important enough that they should be offered to the
> logging system, hence I changed DirectoryWatcher to default to
> LOG_ERROR.
> - If a Configuration from the config-admin contains no log settings, I
> altered the code to use the global log level as a default. Vice versa,
> a Configuration can still override the global log level.
> - Stuff like corrupt bundles may simply go unnoticed because those are
> logged as warnings. I've altered the logging level for non-recoverable
> situations to see everything of interest as an error.
> - When I configured the "felix.fileinstall.start.level" setting, the
> component wouldn't run update or refresh when the framework's start
> level is too low. I've introduced a new setting
> "felix.fileinstall.active.level" to configure the scan behaviour, e.g.
> so you can set it higher than the system bundle start-level so that
> the framework bundles resolve first. By default, the file install
> component now always updates, irregardless of the
> "felix.fileinstall.start.level" setting.
> - The bundle start level is now only set when a bundle is installed
> and not every time a bundle gets restarted. I'd expect that a user
> should be able to override the bundle start level instead of it being
> reset each time the file install component triggers a bundle start.
>
> The logging stuff is filed in issue
> https://issues.apache.org/jira/browse/FELIX-3373 , whereas the start
> level stuff is filed as
> https://issues.apache.org/jira/browse/FELIX-3346 .
>
>
> Due to my changes, the tests started to fail. I added some code to the
> setup method so that the bundle context expects certain getProperty
> calls.
> While I was at it, I've also updated them to use the EasyMock 2 API -
> now they no longer show those annoying deprecated warnings in Eclipse.
> The second patch ("fileinstall-easymock2.patch") includes these changes.
>
>
> Both patches are made against the trunk version. For the record, my
> ICLA recently got filed with the Apache foundation, and I agree to
> release these changes under the ASL v2.
>
> If there are any comments after reviewing both patch files, just let me know.
>
>
> With best regards,
>
> Bert Jacobs
