[ 
https://issues.apache.org/jira/browse/FELIX-3334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227525#comment-13227525
 ] 

Carsten Ziegeler commented on FELIX-3334:
-----------------------------------------

Yeah, I liked this feature as well but I fear those questions in reality. A lot 
of interesting things could happen which in most cases might be unwanted.
Maybe we should just use a different way of pluggability which allows for more 
predictable scenarios:
- moving the default implementation of the store into a separate bundle and 
making the dependency required would be one solution
- require people to create their own prefs bundle where the store impl has to 
be inside the prefs bundle would be another one
Not nice either....

                
> PreferencesManager can throw NPE after being stopped.
> -----------------------------------------------------
>
>                 Key: FELIX-3334
>                 URL: https://issues.apache.org/jira/browse/FELIX-3334
>             Project: Felix
>          Issue Type: Bug
>          Components: Preferences Service
>    Affects Versions: prefs-1.0.4
>            Reporter: J.W. Janssen
>            Assignee: Carsten Ziegeler
>              Labels: patch
>             Fix For: prefs-1.0.6
>
>         Attachments: felix-prefs-3334-2.patch, quickfix-new.patch
>
>
> PreferencesManager#bundleChanged tries to intercept bundles that are 
> uninstalled. However, if the PreferencesManager itself is stopped, it does 
> not unregister itself as bundle listener, causing possible NPEs when other 
> bundles depending on the preferences service are stopped later on, for 
> example during a shutdown.
> I've got a patch available, will attach it to this issue to be applied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to