UPnP Plugin device tracking is error-prone
------------------------------------------

                 Key: FELIX-3426
                 URL: https://issues.apache.org/jira/browse/FELIX-3426
             Project: Felix
          Issue Type: Bug
          Components: Web Console
    Affects Versions: webconsole-upnp-plugin-1.0.0  
            Reporter: Valentin Valchev
            Assignee: Valentin Valchev
            Priority: Critical
             Fix For: webconsole-upnp-plugin-1.0.2


Sometimes, when one device appears, and another is removed, the plugin is 
unregistered. The reason is that the addingService() and removedService() in 
the activator are not synchronized.

In addition, in removedService() the code fragment is absolutely incorrect:
       if (tracker.getTrackingCount() == 0 && plugin != null)
        {
            plugin.unregister();
            this.plugin = null;
        }

The reason is that 'tracking count' is always incremented - no matter if a 
service is registered, modified or unregistered. It is NOT the count of tracked 
services.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to