[ 
https://issues.apache.org/jira/browse/FELIX-3424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245666#comment-13245666
 ] 

Marcel Offermans commented on FELIX-3424:
-----------------------------------------

AdapterFilterIndex:
- getAllServiceReferences(..) -> Fetches a list in a synchronized block and 
iterates over it outside of that block. As far as I can see, it makes no copy 
of the list. Can you be sure nobody else can manipulate that list while we're 
iterating over it here?
- serviceChanged() -> Calls listeners from within a synchronized block. Since 
we cannot know what listeners do in their implementation, it is probably unsafe 
to call them while holding a lock.

I also found a few references to "beinformed" in the comments (which we should 
probably replace with org.foo or something similar).
                
> Add support for changed callbacks on Aspect services.
> -----------------------------------------------------
>
>                 Key: FELIX-3424
>                 URL: https://issues.apache.org/jira/browse/FELIX-3424
>             Project: Felix
>          Issue Type: Improvement
>          Components: Dependency Manager
>            Reporter: Xander Uiterlinden
>            Assignee: Xander Uiterlinden
>            Priority: Minor
>
> Recently changed callbacks have been introduced for service dependencies and 
> adapter services. This functionality would also be really useful on aspect 
> services.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to