[ 
https://issues.apache.org/jira/browse/FELIX-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287316#comment-13287316
 ] 

Tuomas Kiviaho commented on FELIX-3381:
---------------------------------------

A small fix shown below would allow using {{manifest}} goal - without having to 
set {{rebuildBundle}} option - for tests as well. It seems that 
{{artifact.file}} is preferred over {{outputDirectory}} although the behavior 
elsewhere in the code seems to be vice versa.

{code}

Index: src/main/java/org/apache/felix/bundleplugin/ManifestPlugin.java
===================================================================
--- src/main/java/org/apache/felix/bundleplugin/ManifestPlugin.java     
(revision 1293123)
+++ src/main/java/org/apache/felix/bundleplugin/ManifestPlugin.java     
(working copy)
@@ -164,10 +164,10 @@
             return buildOSGiBundle( project, instructions, properties, 
classpath );
         }
 
-        File file = project.getArtifact().getFile();
+        File file = getOutputDirectory();
         if ( file == null )
         {
-            file = getOutputDirectory();
+            file = project.getArtifact().getFile();
         }
 
         if ( !file.exists() )
{code}
                
> Support for {maven-test-resources} and {maven-test-sources} placeholders
> ------------------------------------------------------------------------
>
>                 Key: FELIX-3381
>                 URL: https://issues.apache.org/jira/browse/FELIX-3381
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven Bundle Plugin
>            Reporter: Tuomas Kiviaho
>            Priority: Minor
>
> I've found the plugin suitable for producing test bundles although bundle 
> plugin states that test scope isn't supported.
> Currently I have to manually keep up with the test resources/sources so that 
> my test fragment bundle wouldn't be considering {maven-resources} and 
> {maven-sources}. This is quite ok compared to having a proper test-bundle 
> goal but I'd love to see corresponding {maven-test-resources} and 
> {maven-test-sources} placeholder support which would streamline the 
> configuration. 
> Now I'm getting WARN messages when I tamper with Include-Resource 
> _sourcepath. It is also quite error prone to manually list multiple resource 
> and source locations. Only classifier and outputDirectory have to be 
> configured in addition to these instructions and dependency embedding works 
> also when transitive dependencies are not used (in fact test scope isn't even 
> transitive)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to