Hi, +1 on also fixing cometd. Thanks !
You should list the included files in the DEPENDENCIES file and if the included files come with the requirement to notice this inclusion, they have to be added to the NOTICE file, too. Regards Felix Am 05.06.2012 um 11:59 schrieb Xander Uiterlinden: > Ok, thanks. I'll do that. > > I (locally) upgraded jetty to the latest 7 version (7.6.3) and therefore > also had to upgrade the cometd dependencies which led me to the cometd > sample project. > I fixed the sample to work with the upgraded cometd version. Previously the > example needed some cometd/dojo javascript files which were not included in > the sample. Is this on purpose ? I think it'd be nice when the sample can > actually be run out-of-the-box, and therefore would like to include these > javascript files from dojo/cometd. Cometd itself is also published under > the Apache 2.0 license. Are there any special requirements I have to watch > when including these files in the cometd sample project? > > Cheers, > > Xander > > 2012/6/4 Rob Walker <r...@ascert.com> > >> Yep - I'd agree with Felix, if it works and takes us forward then go for >> it. >> >> I worked with Richard on the original HTTP service, and do some occasional >> mods/fixes to the newer felix-http one. So let me know if I can help out. >> We use the HTTP service in our app. Once I have my current R&D stream done >> and released (eta mid July) I can give it a spin to see if it all works our >> side. >> >> -- Rob >> >> >> On 03/06/2012 12:49 PM, Felix Meschberger wrote: >> >>> Hi, >>> >>> Originally Sten Roger Sandvik contributed the new HTTP Service >>> implementation. Recently I did work in that area. But I am not constantly >>> on. >>> >>> I suggest you go ahead and commit ... >>> >>> As long as you don't break anything, there should not be a big problem. >>> >>> Regards >>> Felix >>> >>> Am 03.06.2012 um 11:25 schrieb Xander Uiterlinden: >>> >>> All, >>>> >>>> A while ago I submitted a patch to JIRA issue >>>> https://issues.apache.org/**jira/browse/FELIX-2292<https://issues.apache.org/jira/browse/FELIX-2292>. >>>> I would really like this >>>> patch to be applied to the trunk. What would be the best way to get this >>>> done ? I do have comitter rights on the Felix project since I'm doing >>>> work >>>> on the dependency manager, but am a bit hesitant to just commit code on >>>> other subprojects. >>>> >>>> I have some other idea's/requirements for felix-http, who of us/you are >>>> all >>>> currently playing an active role in this subproject ? >>>> >>>> Cheers, >>>> >>>> Xander >>>> >>> >> -- >> >> >> Ascert - Taking systems to the edge >> r...@ascert.com >> +27 87 550 1701 >> www.ascert.com >> >>
