[ 
https://issues.apache.org/jira/browse/FELIX-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405819#comment-13405819
 ] 

Felix Meschberger commented on FELIX-3415:
------------------------------------------

Fix is not as simple because the update request could be routed through OBR 
which ignores the bundle's location. So disabling the update button due to 
"malformed" bundle location URL is not adequate.

To do it right, the check would actually have to check both the bundle location 
and the OBR for updates, which might be way too expensive.

Alternatively, we just keep the button as it is and do nothing to fix this. In 
reality, nothing dramatic happens if neither OBR nor the bundle's location 
provide an update.
                
> Disable update button if bundle location URL is invalid
> -------------------------------------------------------
>
>                 Key: FELIX-3415
>                 URL: https://issues.apache.org/jira/browse/FELIX-3415
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-3.1.8
>            Reporter: Felix Meschberger
>
> When clicking the update button on any bundle, the bundle location (or the 
> bundle's update location header) is taken as an URL to retrieve a bundle 
> update. If the bundle's update location header is not set and the bundle 
> location is not a valid URL, this of course fails.
> We should probably disable the update button if the bundle location URL fails 
> to be created:
>   try {
>      new URL(bundleLocation);
>      updatePossible = true;
>   } catch (MalformedURLException mue) {
>      updatePossible = false;
>   }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to