Jason Woodrich created FELIX-3582:
-------------------------------------
Summary: finalName not properly populated in maven-bundle-plugin
with buildnumber-maven-plugin
Key: FELIX-3582
URL: https://issues.apache.org/jira/browse/FELIX-3582
Project: Felix
Issue Type: Bug
Components: Maven Bundle Plugin
Affects Versions: maven-bundle-plugin-2.3.7
Reporter: Jason Woodrich
Priority: Minor
If the finalName element in the build section contains elements that are
dynamically populated, such as ${buildNumber}, and the packaging element is set
to bundle, the literal string "${buildNumber}" will appear in the jar file
that's produced. I took a look at the source code and found what I believe to
be the problem and applied a fix in a local copy of the source code. In
org/apache/felix/bundleplugin/BundleInfo.java:1113 there is this line of code:
{code}
String finalName = currentProject.getBuild().getFinalName();
{code}
I removed this line (1113) and added the following near the top of the class:
{code}
/**
* Name of the generated JAR.
* @parameter alias="jarName" expression="${jar.finalName}"
default-value="${project.build.finalName}"
* @required
*/
private String finalName;
{code}
This properly populates the finalName in the jar file and all of the unit tests
pass. I'm not sure if this affects anything else but as far as I can tell it
doesn't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
