[
https://issues.apache.org/jira/browse/FELIX-3590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411971#comment-13411971
]
Christian Schneider edited comment on FELIX-3590 at 7/11/12 10:19 PM:
----------------------------------------------------------------------
The system properties can change in some cases but perhaps we can live with the
fact that the change is not reflected. I will check with the other Karaf
developers if copying would be enough. It definately would be the simplest
option.
was (Author: [email protected]):
The can change in some cases but perhaps we can live with the fact that the
change is not reflected. I will check with the other Karaf developers if
copying would be enough. It definately would be the simplest option.
> Add system property resolution to CommandSessionImpl
> ----------------------------------------------------
>
> Key: FELIX-3590
> URL: https://issues.apache.org/jira/browse/FELIX-3590
> Project: Felix
> Issue Type: Improvement
> Components: Gogo Runtime
> Affects Versions: gogo.runtime-0.10.0
> Reporter: Christian Schneider
> Priority: Minor
> Fix For: gogo.runtime-0.12.0
>
>
> Currently we wrap the CommandProcessor and CommandShell in karaf to simply
> add the resolution of system properties.
> See org.apache.karaf.shell.console.impl.jline.Activator in the karaf console
> module.
> In the innermost code it is only the following we override in
> CommandSessionImpl.
> public Object get(String name) {
> Object val = super.get(name);
> if (val == null) {
> val = System.getProperty(name);
> }
> return val;
> }
> So I propose to add this system property resolution to gogo. This would allow
> us to remove all the wrapping code in karaf.
> If you are interested I can provide a patch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
