On 7/19/12 5:26 PM, Felix Meschberger wrote: > Hi, > > Am 18.07.2012 um 19:26 schrieb Richard S. Hall: > >> On 7/18/12 12:08 , Marcel Offermans wrote: >>> On 7/18/12 06:36 , Jan Willem Janssen wrote: >>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >>>> >>>> Hi list, >>>> >>>> I've written a UserAdmin implementation that I'd like to >>>> donate to the Felix project, see [1]. >>> >>>> [1] https://issues.apache.org/jira/browse/FELIX-3600 >>> Thanks, Jan Willem, I took a look at the code and all the tests >>> (over 200, wow!) and it's definitely looking good to me. It >>> also has a plugable store backend, which is nice if people want >>> to hook it up to existing databases and repositories. I think >>> we should definitely accept this donation! >> >> I'm inclined to agree... > > So am I. > > The RoleChangeListener.java is missing the ASL header and the > bundle plugin configuration IMHO needs some tweeking (e.b. > versioning the package export, replacing Export-Service by the > respective Capability header)
Ok; I've apparently missed those. I'll update them, and include a new (signed) version in the JIRA issue. Thanks for looking into this! -- Met vriendelijke groeten | Kind regards Jan Willem Janssen | Software Architect +31 631 765 814 /My world is:/ Luminis Technologies B.V. IJsselburcht 3 6825 BS Arnhem +31 88 586 46 30 http://www.luminis-technologies.com http://www.luminis.eu KvK (CoC) 09 16 28 93 BTW (VAT) NL8169.78.566.B.01
