[ 
https://issues.apache.org/jira/browse/FELIX-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422413#comment-13422413
 ] 

Guillaume Nodet commented on FELIX-3609:
----------------------------------------

Interesting, do you have any more infos ?  Are hooks supposed to be sorted ?
I've followed the code path and they seemed to always end up being sorted the 
same way, so I thought it was a good idea to keep them sorted all time.

The only access to the m_allHooks I found is from getHooks() which does the 
sort every time before returning.  So I kinda fail to see what kind of 
regression it could cause.

Anyway, sorting all the hooks each time they are accessed (so each time a 
service listener is added/removed or a search for service references) is quite 
cpu intensive.  I'd still like to get that fix somehow if possible.
                
> Small optimizations
> -------------------
>
>                 Key: FELIX-3609
>                 URL: https://issues.apache.org/jira/browse/FELIX-3609
>             Project: Felix
>          Issue Type: Improvement
>          Components: Framework
>            Reporter: Guillaume Nodet
>            Assignee: Guillaume Nodet
>             Fix For: framework-4.2.0
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to