[ 
https://issues.apache.org/jira/browse/FELIX-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473940#comment-13473940
 ] 

Felix Meschberger commented on FELIX-3704:
------------------------------------------

Yes, we might want to make sure the queue is empty before terminating it (until 
recently there wasn't going on much in the queue anyway because most of the 
asynchronous tasks for which the queue has been built have been converted to 
synchronous tasks)

We should not wait (too long) for the queue to go empty before terminating it 
because the stop method is called synchronously and this might lead to 
deadlocks.


                
> [DS] ds shutdown should wait for ComponentActorThread task queue to complete 
> before finishing
> ---------------------------------------------------------------------------------------------
>
>                 Key: FELIX-3704
>                 URL: https://issues.apache.org/jira/browse/FELIX-3704
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-1.8.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: scr-1.8.0
>
>
> Right now Activator.stop doesn't deal with the situation of the 
> ComponentActorThread task queue having undone actions on it.  In particular 
> it adds the terminator task and immediately turns off logging which may have 
> the effect of the "component actor thread terminating" message going to 
> System.out.
> Should we check the queue is empty before disposing the components?
> How about before removing logging?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to