[
https://issues.apache.org/jira/browse/FELIX-3888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569808#comment-13569808
]
Felix Meschberger edited comment on FELIX-3888 at 2/3/13 4:41 PM:
------------------------------------------------------------------
>Aries Version Checker:
Thanks !. I wanted to have a look into this for a long time.
> I can make "null" do this and also move the regexp matching to ScrCommand.
Yes, I think null makes sense to mean "all" -- But really I like the idea of
the shell command supporting a regexp.
> "directly expose the Gogo Shell API"
The API is taking the component identification plus the stdout and stderr
streams to write to. The question I wanted to raise was whether there would be
not a more appropriate API for a service interface. Like returning a
StringBuilder (or String) and throwing in case of an error ?
> the patch
* Is it required to hard code the Bundle-Version header in the bundle plugin ?
* Otherwise LGTM
Thanks alot.
was (Author: fmeschbe):
Thanks for the Aries Checker Plugin. I wanted to have a look into this for
a long time.
> I can make "null" do this and also move the regexp matching to ScrCommand.
Yes, I think null makes sense to mean "all" -- But really I like the idea of
the shell command supporting a regexp.
> "directly expose the Gogo Shell API"
The API is taking the component identification plus the stdout and stderr
streams to write to. The question I wanted to raise was whether there would be
not a more appropriate API for a service interface. Like returning a
StringBuilder (or String) and throwing in case of an error ?
> [DS] Expose the insides of ScrCommand as a service directly and enhance it
> --------------------------------------------------------------------------
>
> Key: FELIX-3888
> URL: https://issues.apache.org/jira/browse/FELIX-3888
> Project: Felix
> Issue Type: Improvement
> Components: Declarative Services (SCR)
> Affects Versions: scr-1.6.4
> Reporter: David Jencks
> Fix For: scr-1.6.4
>
> Attachments: FELIX-3888-1.diff, FELIX-3888-2.diff
>
>
> I have an environment where I'd like the basic capabilities of outputting the
> DS info as text but not through the console. We've been using the old Felix
> command but this has always been odd and is getting too complicated.
> Therefore I'd like to expose the ScrCommand as a service directly. I'm
> proposing to expose this only if an optional config admin property
> ds.info.service is set to true.
> To further support this I'd like to make ScrCommand.getInfo(String id....) be
> able to return info for all components. I'm proposing to do this by letting
> id be a regexp to match, so I can use ".*" and get all components. (This is
> implemented in scrService.getComponents(String componentIdentifier))
> For components from multiple bundles I'd like to sort the results by bundleId
> and componentId, marking the bundle id changing.
> I'd like to modify the list command to sort the results by component id.
> The patch has a bit of java-5 updating that I missed the first time around.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
