[
https://issues.apache.org/jira/browse/FELIX-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13572441#comment-13572441
]
Richard S. Hall commented on FELIX-3411:
----------------------------------------
It is not clear to me that your patch does anything.
Currently, we calculate low and high and then we either increment active level
from low to high or decrement it from high to low depending on whether we are
raising or lowering, respectively. At each step, we start (or stop) bundles
whose start level matches the given step.
In other words, m_activeStartLevel steps from low to high (or high to low)
inclusive, so there is no need to verify that tuple.m_level is between low and
high because if it is equal to m_activeStartLevel then by definition it is
between low and high (inclusive).
Unless I'm missing something.
> The implementation of
> org.osgi.service.startlevel.StartLevel#setStartLevel(int) does not follow the
> spec
> --------------------------------------------------------------------------------------------------------
>
> Key: FELIX-3411
> URL: https://issues.apache.org/jira/browse/FELIX-3411
> Project: Felix
> Issue Type: Bug
> Components: Framework
> Affects Versions: framework-4.0.2
> Reporter: Yasuhiro Kawame
> Assignee: Richard S. Hall
> Fix For: framework-4.2.0
>
>
> I think that the implementation of Changing the Active Start Level is
> different from Spec.
> see:
> OSGi Service Platform Core Specification Release 4, Version 4.3, Figure 8.2
> page154
> Move to requested start level R, active level is A, B is a bundle's start
> level
> Spec:
> if (A < R)
> while (A < R) {
> A = A + 1
> Start All bundles where B = A
> }
> Implementation:
> if (A < R)
> Start All bundles where B <= R
> A = R
> Similarly, if A > R.
> Javadoc:
> http://www.osgi.org/javadoc/r4v43/org/osgi/service/startlevel/StartLevel.html#setStartLevel%28int%29
> http://www.osgi.org/javadoc/r4v43/org/osgi/framework/startlevel/FrameworkStartLevel.html#setStartLevel(int,
> org.osgi.framework.FrameworkListener...)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
