Hi I am looking into cutting a Web Console release soon, which will require a release of the "inventory" bundle first. This is the bundle previously called status having been renamed because the maven module name "status-printer" was not congruent with the bundle symbolic name o.a.f.status.
I have been looking into this module a bit and would like to share some feedback: * IIUIC an InventoryPrinter registered with a .category property will be registered with the web console as a proxy plugin with the respective property (allowing the InventoryPrinter to be accessed by its own URL). If the .category property is not set, the default Inventory category is used. I think we should not have such a .category property and these adapter plugins should always be registered with the Inventory category. * Configurability: Should the inventory- URL prefix and the Inventory category be configurable ? * Should the ZipAttachementProvider really extend the InventoryPrinter interface ? I rather think it should not extend the InventoryPrinter interface. Rather it should be used as a "marker with API": When writing the ZIP, the InventoryPrinter services are checked whether they also implement the ZipAttachementProvider and should be called accordingly. * Minor: Source Code Formatting should be adapted to our coding conventions. * What are the InventoryPrinterHandler and InventoryPrinterManager interfaces used for ? Looks like they are used internally in the Inventory bundle -- are they used externally ? I have the impression, this API is not required. * API: We should probably tag the interfaces with the BND @ConsumerType and @ProviderType annotations. * While I think "Inventory" as a name is probably better (and less confusing) than Configuration Status or Status or Status Printer, I am not really convinced (and still fear the name is confusing). Maybe some native english speaker has a better name for that ? Regards Felix PS: Releasing the Inventory bundle blocks the Web Console release because the "all-in-one" profile of the Web Console embeds the Inventory bundle.
