[ 
https://issues.apache.org/jira/browse/FELIX-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13641627#comment-13641627
 ] 

Carsten Ziegeler commented on FELIX-4036:
-----------------------------------------

I've created this clone of FELIX-4035 to handle the case 1 and 2 : as Felix 
points out in the original issue, the above code is correct - however we could 
check the metatype.properties file.
                
> Check for label/description of component and properties when metatype 
> information is generated
> ----------------------------------------------------------------------------------------------
>
>                 Key: FELIX-4036
>                 URL: https://issues.apache.org/jira/browse/FELIX-4036
>             Project: Felix
>          Issue Type: Improvement
>          Components: Maven SCR Plugin
>            Reporter: Jörg Hoh
>
> When using SCR annotations you can easily create services and components, 
> which do not have proper labels and descriptions. We should warn in these 
> cases.
> Case 1: 
> {code}
> @Component(metatype=true)
> @Property(...)
> {code}
> When a metatype is being generated, a label and a description should be 
> provided as well. The warn message could be "A metatype should always have a 
> label and a description".
> Case 2:
> {code}
> @Component(metatype=true)
> @Property(name="foo",value="bar")
> {code}
> When a metatype is being generated, containing properties which are not 
> marked as private, a warning "Non-private properties in a metatype should 
> always have a label and a description" should be logged.
> Case 3:
> {code}
> @Component(metatype=true)
> {code}
> In case a metatype is being created without any property, a warning "A 
> metatype should have properties; in case no properties are wanted, consider 
> to use 'metatype=false'" should be logged.
> (inspired by FELIX-4033, thanks Robert)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to