[
https://issues.apache.org/jira/browse/FELIX-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved FELIX-4035.
-------------------------------------
Resolution: Fixed
Fix Version/s: scr generator 1.6.0
scr ant task 1.6.0
maven-scr-plugin-1.12.0
I've added a warning for case 3
> Issue warning messages when metatype is be created, but no properties are
> defined
> ---------------------------------------------------------------------------------
>
> Key: FELIX-4035
> URL: https://issues.apache.org/jira/browse/FELIX-4035
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Jörg Hoh
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.12.0, scr ant task 1.6.0, scr
> generator 1.6.0
>
>
> When using SCR annotations you can easily create services and components,
> which do not have proper labels and descriptions. We should warn in these
> cases.
> Case 1:
> {code}
> @Component(metatype=true)
> @Property(...)
> {code}
> When a metatype is being generated, a label and a description should be
> provided as well. The warn message could be "A metatype should always have a
> label and a description".
> Case 2:
> {code}
> @Component(metatype=true)
> @Property(name="foo",value="bar")
> {code}
> When a metatype is being generated, containing properties which are not
> marked as private, a warning "Non-private properties in a metatype should
> always have a label and a description" should be logged.
> Case 3:
> {code}
> @Component(metatype=true)
> {code}
> In case a metatype is being created without any property, a warning "A
> metatype should have properties; in case no properties are wanted, consider
> to use 'metatype=false'" should be logged.
> (inspired by FELIX-4033, thanks Robert)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
