[
https://issues.apache.org/jira/browse/FELIX-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656964#comment-13656964
]
Julian Sedding commented on FELIX-4063:
---------------------------------------
Your change is slightly better than my patch, this looks good to me.
I think this will still create warnings for the following:
@SlingServlet(generateComponent = false, resourceTypes = { "foo/bar" })
@Component(metatype = false)
In order to get around this, I think we would need to put more logic into
ClassDescription and delay the descision whether properties are made private or
not.
Anyway, I think this is good enough for now. Thanks for the quick resolution.
> Avoid warnings when using @SlingServlet and @SlingFilter annotations
> --------------------------------------------------------------------
>
> Key: FELIX-4063
> URL: https://issues.apache.org/jira/browse/FELIX-4063
> Project: Felix
> Issue Type: Bug
> Components: Maven SCR Plugin
> Affects Versions: scr annotations 1.9.2
> Reporter: Julian Sedding
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: FELIX-4063.patch
>
>
> FELIX-4033 introduced build-time warning messages for private properties
> defined for components with metatype = false.
> The @SlingServlet and @SlingFilter annotations set several properties to be
> private, thus causing warnings like the following to be reported if metatype
> = false (the default value).
> [WARNING] /path/TheServlet.java [0:0]: Property sling.servlet.methods in
> class TheServlet is set as private. This is redundant as no metatype will be
> generated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
