[ 
https://issues.apache.org/jira/browse/FELIX-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Felix Meschberger resolved FELIX-4196.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: http-sslfilter-1.0.0
         Assignee: Felix Meschberger

Fixed in Rev. 1515389 adding the check before changing the StringBuffer value.

For completeness, added some unit tests in Rev. 1515392
                
> If proxy or SSL Offloader already sends https urls the SSLFilter wil created 
> a httpss URL
> -----------------------------------------------------------------------------------------
>
>                 Key: FELIX-4196
>                 URL: https://issues.apache.org/jira/browse/FELIX-4196
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-sslfilter-1.0.0
>            Reporter: Kris Barnhoorn
>            Assignee: Felix Meschberger
>             Fix For: http-sslfilter-1.0.0
>
>
> Hi,
> If proxy or SSL Offloader already sends https urls the SSLFilter wil created 
> a httpss URL
> See code in 
> https://fisheye6.atlassian.com/browse/felix/trunk/http/sslfilter/src/main/java/org/apache/felix/http/sslfilter/internal/SslFilterRequest.java?r=1394715
> {code}
>    public StringBuffer getRequestURL()
>    {
>        if (this.requestURL == null) {
>            // insert an 's' after the http scheme
>            StringBuffer tmp = super.getRequestURL();
>            tmp.insert(4, 's');
>            this.requestURL = tmp.toString();
>        }
>  
>        return new StringBuffer(this.requestURL);
>    }
> {code}
> A replace of "http://"; to "https://"; will be less buggy.
> Furthermore an option to not rewrite from http to https would be good as in 
> some cases this is not desirable.
> Kind regards,
> Kris.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to