Yes, it would be good to sort out the issues surrounding FELIX-3687/FELIX-4190. Richard/Guillaume any thoughts here?
At this point we have all the Core R5 CT tests passing (yay!). There is one subtask of FELIX-4128 still open. That's really just a nice-to-have cleanup that I'd like to do soon. Cheers, David On 18 January 2014 22:23, David Jencks <[email protected]> wrote: > I hope that someone cleans up the mess around > https://issues.apache.org/jira/browse/FELIX-3687 > and > https://issues.apache.org/jira/browse/FELIX-4190 > before a release candidate. > > In the first issue I proposed a patch, Richard pointed out a problem, and I > suggested a possible solution and haven't gotten any comments. > > In the 2nd issue Guillaume committed a fix that is invalid and AFAIK it has > not been corrected. > > thanks > david jencks > > On Jan 17, 2014, at 8:40 AM, David Bosschaert <[email protected]> > wrote: > >> On 17 January 2014 16:16, Carsten Ziegeler <[email protected]> wrote: >>> +1 for a new framework release, it would be great to have full R5 support, >>> but if that is not supposed to happen soon >> >> Full disclosure: >> I tried my hand on those resolver related open issues, but had the >> feeling that I didn't understand the Felix code well enough for it. >> The resolver is a pretty complex beast, especially since it's >> recursive/re-entrant and I found that fixing one little issue would >> cause tons of other things to fall over elsewhere ;) In the end I >> often came up with a patchwork of fixes for one resolver CT test >> failure where I had the feeling that it could be done more elegantly. >> >> so in the end I abandoned my attempts here... I think those remaining >> resolver issues are for someone who really knows the felix resolver >> code inside out :) >> >> Cheers, >> >> David >
