[
https://issues.apache.org/jira/browse/FELIX-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
J.W. Janssen resolved FELIX-4410.
---------------------------------
Resolution: Fixed
Refactored the commit/rollback actions by introducing an AbstractAction that
properly handles checked and unchecked exceptions, making the implementations a
little more resilient against unexpected situations. All thrown exceptions are
now properly handled. See rev #1563873.
[~marrs]: please retest & close if you're satisfied with the solution.
> Exceptions during rollback are not always properly handled
> ----------------------------------------------------------
>
> Key: FELIX-4410
> URL: https://issues.apache.org/jira/browse/FELIX-4410
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Affects Versions: deploymentadmin-0.9.5
> Reporter: Marcel Offermans
> Assignee: J.W. Janssen
>
> In DeploymentSessionImpl.call(...) there are a couple of locations that
> trigger a rollback. It is currently possible for the rollback itself to
> create an exception. Not all commands that participate in the rollback
> currently catch all such exceptions. The spec describes in 114.7.1 that the
> rollback should always do its best to reverse all effects, and log any
> problems it ran into. We should make a better effort to do so. Therefore I
> suggest a review of all those commands where we explicitly check thrown
> exceptions and deal with them.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
