[
https://issues.apache.org/jira/browse/FELIX-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919458#comment-13919458
]
Carsten Ziegeler edited comment on FELIX-4393 at 3/4/14 2:47 PM:
-----------------------------------------------------------------
I see your point, however supporting this from the DS tooling if DS is not
supporting it, sounds a little bit wrong
So how about this:
- in general the scr plugin will issue a warning if @Property is used on a non
static field
- we provide a switch (default off) which if enabled:
1. does not issue the warning above
2. behaves slightly different than today: for non static fields: if no name
specified, it takes the name of the field; if no value specified it takes the
initial value of the field
was (Author: cziegeler):
I see your point, however supporting this from the DS tooling if DS is not
supporting it, sounds a little bit wrong
So how about this:
- in general the scr plugin will issue a warning if @Property is used on a non
static field
- we provide a switch (default off) which if enabled:
1. does not issue the warning above
2. behaves slightly different than today: if no name specified, it takes the
name of the field; if no value specified it takes the initial value of the field
> @Property should accept empty name values on fields
> -----------------------------------------------------
>
> Key: FELIX-4393
> URL: https://issues.apache.org/jira/browse/FELIX-4393
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: james strachan
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin 1.15.2, scr ant task 1.9.2, scr
> generator 1.8.4
>
>
> it'd be nice if @Property behaved like various other annotations (e.g.
> @Inject / @Resource) so that if a name is not specified and @Property is
> specified on a field, then the name value defaults to the field name.
> It looks like name is optional with a default of "" - so its just the maven
> scr plugin which seems to barf if name is empty generating this kind of
> compile error:
> {code}
> @Property : Property name can not be empty.
> {code}
> It'd be nice if the name was optional; it makes the code more DRY and keeps
> things more refactoring safe etc
--
This message was sent by Atlassian JIRA
(v6.2#6252)
