Hi Pierre, Sorry about the delay. The exception seems to be caused by https://github.com/apache/felix/commit/ab18b4a3bdcd654e42eaa109d6d7064ab30d360d#diff-77f7cca80e43164a9c73acd5c55ed128 The new ConcurrentHashMap which is used in place of the HashMap does not support null values, so a NPE is thrown. That's clearly a problem as session.put(key, null) is the only way to "remove" a variable from the session. I'll cancel this vote, fix the problem and start a new release candidate. Thx !
Cheers, Guillaume 2014-03-01 10:12 GMT+01:00 Pierre De Rop <[email protected]>: > Hi Guillaume, > > May be I missed something, but when doing a basic test, then I'm getting > this exception: > > (I just installed the felix 4.2.1 distribution with jdk 1.7.0_45, and > replaced the old org.apache.felix.gogo.runtime-0.10.0.jar by the new > org.apache.felix.gogo.runtime-0.12.0.jar bundle): > > -> > > [nxuser@nx0012 felix-framework-4.2.1]$ java -jar bin/felix.jar > ____________________________ > Welcome to Apache Felix Gogo > > gogo: NullPointerException: null > java.lang.NullPointerException > at > java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1124) > at > > org.apache.felix.gogo.runtime.CommandSessionImpl.put(CommandSessionImpl.java:156) > at org.apache.felix.gogo.shell.Shell.source(Shell.java:196) > at org.apache.felix.gogo.shell.Shell.gosh(Shell.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at > > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at > org.apache.felix.gogo.runtime.Reflective.invoke(Reflective.java:137) > at > org.apache.felix.gogo.runtime.CommandProxy.execute(CommandProxy.java:82) > at > org.apache.felix.gogo.runtime.Closure.executeCmd(Closure.java:477) > at > org.apache.felix.gogo.runtime.Closure.executeStatement(Closure.java:403) > at org.apache.felix.gogo.runtime.Pipe.run(Pipe.java:108) > at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:183) > at org.apache.felix.gogo.runtime.Closure.execute(Closure.java:120) > at > > org.apache.felix.gogo.runtime.CommandSessionImpl.execute(CommandSessionImpl.java:92) > at org.apache.felix.gogo.shell.Activator.run(Activator.java:75) > at java.lang.Thread.run(Thread.java:744) > > I'm using the following bundles: > > org.apache.felix.bundlerepository-1.6.6.jar > org.apache.felix.gogo.command-0.12.0.jar > org.apache.felix.gogo.runtime-0.12.0.jar > org.apache.felix.gogo.shell-0.10.0.jar > > > do you also have this exception ? > > kind regards; > /Pierre > > > > On Wed, Feb 26, 2014 at 12:14 PM, Guillaume Nodet <[email protected]> > wrote: > > > I'm calling a vote on Felix Gogo Runtime. > > > > Staging repository: > > https://repository.apache.org/content/repositories/orgapachefelix-1008/ > > > > You can use this UNIX script to download the release and verify the > > signatures: > > http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh > > > > Usage: > > sh check_staged_release.sh 1008 /tmp/felix-staging > > > > Changes: > > ** Bug > > * [FELIX-4336] - The use of inheritable thread locals in ThreadIO can > > cause problems > > ** Improvement > > * [FELIX-3590] - Add system property resolution to CommandSessionImpl > > * [FELIX-4363] - The CommandSession get/set methods are not thread > safe > > > > Please vote to approve this release: > > > > [ ] +1 Approve the release > > [ ] -1 Veto the release (please provide specific comments) > > > > Cheers, > > Guillaume > > >
