Well, I forgot Felix doesn't use git yet. Maybe we should discuss switching. I only see benefits fwiw.
2014-03-18 13:29 GMT+01:00 Guillaume Nodet <[email protected]>: > Well, there are benefits of using git branches and PRs rather than > patches: it's easier and preserve the authorship of the patch. > I like it. > > > 2014-03-18 13:23 GMT+01:00 Richard S. Hall <[email protected]>: > > I would assume this is an automated system... >> >> If so, why can they not just attach the patch to the issue so we can keep >> our JIRA issues self contained and not have to start relying on a >> third-party patch hosting system? >> >> -> richard >> >> >> On 3/18/14, 07:56 , ASF GitHub Bot (JIRA) wrote: >> >>> [ https://issues.apache.org/jira/browse/FELIX-2702?page= >>> com.atlassian.jira.plugin.system.issuetabpanels:comment- >>> tabpanel&focusedCommentId=13939106#comment-13939106 ] >>> >>> ASF GitHub Bot commented on FELIX-2702: >>> --------------------------------------- >>> >>> GitHub user grgrzybek opened a pull request: >>> >>> https://github.com/apache/felix/pull/5 >>> >>> [FELIX-2702] Start failing bundles when there's a change in bundles >>> state >>> >>> starting bundles. >>> >>> You can merge this pull request into a Git repository by running: >>> >>> $ git pull https://github.com/grgrzybek/felix FELIX-2702 >>> >>> Alternatively you can review and apply these changes as the patch at: >>> >>> https://github.com/apache/felix/pull/5.patch >>> >>> To close this pull request, make a commit to your master/trunk branch >>> with (at least) the following in the commit message: >>> >>> This closes #5 >>> ---- >>> commit dc02abde7d338e175e23dc5cc74172562c2dc386 >>> Author: Grzegorz Grzybek <[email protected]> >>> Date: 2014-03-17T15:49:43Z >>> >>> [FELIX-2702] Monitoring system state to check whether to reattempt >>> starting bundles. >>> >>> ---- >>> >>> >>> File Install should be smarter about starting failed bundles >>>> ------------------------------------------------------------ >>>> >>>> Key: FELIX-2702 >>>> URL: https://issues.apache.org/jira/browse/FELIX-2702 >>>> Project: Felix >>>> Issue Type: Improvement >>>> Components: File Install >>>> Affects Versions: fileinstall-3.0.2 >>>> Reporter: David Hay >>>> Priority: Minor >>>> >>>> When the File Install bundle tries to start a bundle and there are >>>> errors (e.g. unresolved imports), it keeps trying to start that bundle even >>>> though nothing about the system has changed. It seems like File Install >>>> could check if the contents of the felix.fileinstall.dir have changed since >>>> the last time it checked as well as installing a BundleListener to >>>> determine if it's worth trying to start a bundle that failed before. >>>> >>> >>> >>> -- >>> This message was sent by Atlassian JIRA >>> (v6.2#6252) >>> >> >> >
