On 18/06/14 16:34, Karl Pauls wrote:
On Wed, Jun 18, 2014 at 4:11 PM, Jan Willem Janssen <
janwillem.jans...@luminis.eu> wrote:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 18/06/14 16:08, Karl Pauls wrote:
FWIW, I'm not a super big fan of shipping the source in the
binaries as that makes them extra bloated - we should
deploy/release the source.jars via maven and bnd should learn how
to download them from the maven repo or at least provide a way to
attach them manually without forcing the source to be contained in
the jar (if it can't do that already).
*grin* matter of taste, fuel for a good flamewar! I personally hate it
that I need to download additional artifacts before I can make sense
from unknown APIs (not using Maven) ;)
It's not a matter of taste. We ship binaries for convenience and sources
for releases.
Now, the binaries are there so you don't have to build the sources. To make
them contain the sources for developer convenience is yet another level of
convenience added on top at the price of making the binaries a lot bigger
(hampering other use cases - i.e., removing convenience for others). So
it's not a question of taste but a tradeoff (which probably can be
summarized as deployment vs develop convenience).
IMO providing bigger binaries just to save a click for some developers
doesn't sound like the right tradeoff to make.
There are multiple ways to look at this.
Your view is one of them.
I'd pose that the project just lost a bugfix and _maybe_ even a
potential committer because of this issue.
It is trivial to define a profile in the pom and just build either the
'embedded' profile, the 'with sources' profile or both.
I for one just deploy with sources. Makes my audit trail that much
easier and I don't have to do special 'deploy to production' things.
OTOH, it's fairly trivial to run a script to remove the sources, since
they're always in OSGI-OPT folder in the bundle.
Which IMHO opens even more possibilities for an acceptable solution :-)
regards,
Karl
- --
Met vriendelijke groeten | Kind regards
Jan Willem Janssen | Software Architect
+31 631 765 814
/My world is revolving around PulseOn and Amdatu/
Luminis Technologies B.V.
J.C. Wilslaan 29
7313 HK Apeldoorn
+31 88 586 46 30
http://www.luminis-technologies.com
http://www.luminis.eu
KvK (CoC) 09 16 28 93
BTW (VAT) NL8169.78.566.B.01
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJToZ4VAAoJEKF/mP2eHDc4Ew8QAJZlHFkjzE/Q9Zf7l0UPBstA
LE2fxjLMzJFS2GEZ8fg8QxCtt81j+FYzBcXQeCs2LmYSEyDZT5mTSC/LspeA98Vr
8zoY6e2hgGyG7cnXTCZ4ictkRaM+Y7TwtMIKBYhiD7oyqAVmtB4dzQORU0WrLljO
/n0P16LpTs0erVe7bynbdLx4G5G8IoDYcJ8/nep2FvhHlshUD5xdk9CNwj4POU25
tC+6wD7fPPgaseoZXAO9JIi9a4EuZTZ9MQhapGiccr6ylFJefZ7MkZDE7/ikfOF/
c8DlNoj9iZsRX7aETZY2Zsi8ppNPno/KVDDIq2cWrDEePm8/26ycP0kRsmLyz50T
uxvATjqNifQSTx6/6Hw/vokcWtBpmtmKjYDvn1oJqC/IQDiCCtRp6XzJDTAqz4q5
3HMtgkSKuINLeqoLKC5jWSiQMZ8yoeWHBTrxdGmHjdR0ljxWaEYekXpZMsm6n6j7
WBD4aZKKkjHnTJ5LXz8zJWPl72GyL4WmaiucALQ/EIktsL+HXexfN6gqfuBYrzcz
GyFwYyxTi86HBev2lCqn1AIR5J5r2pXkn4uM7xL9PUlk9kPBsqTzTiekZQLhvKaf
V79aSEoTW+B488nq3kxwHSSShlYJoHaiBH4YooKlj3xOn+IiX5AS2cg2D/oCnu1k
DqF2JZOFsRJWBBDGaQZF
=OHAU
-----END PGP SIGNATURE-----
--
Ferry Huberts
