+1 (non-binding) Cheers, Jamie
On Tue, Jun 24, 2014 at 7:56 AM, Stuart McCulloch <mccu...@gmail.com> wrote: > On 24 Jun 2014, at 09:54, Grzegorz Grzybek <gr.grzy...@gmail.com> wrote: > >> +1 (non-binding) >> >> I did a test with latest fabric8 and all went well after little >> modification: >> We had this default: >> >> <Private-Package>!*</Private-Package> >> >> But it seems that it resulted in empty JARs - the above setting overrode >> <Export-Package>io.fabric8.xxx*</Export-Package> >> Shouldn't we use Export-Package with higher priority? > > AFAICT nothing has changed in the bundleplugin wrt. Private-Package (compared > to bundleplugin 2.4.0), but it could be a consequence of the upgrade to bnd > 2.3.0 > >> After changing this to: >> >> <Private-Package /> >> >> all went fine. >> >> regards >> Grzegorz Grzybek >> >> >> 2014-06-23 20:52 GMT+02:00 Jean-Baptiste Onofré <j...@nanthrax.net>: >> >>> +1 (non binding) >>> >>> >>> Regards >>> JB >>> >>> On 06/23/2014 04:05 PM, Stuart McCulloch wrote: >>> >>>> Hi, >>>> >>>> I’ve fixed the issue reported in http://www.mail-archive.com/ >>>> us...@felix.apache.org/msg15423.html and have restaged the 2.5.0 >>>> release... >>>> >>>> We solved 7 issues in this release, the major ones being the bndlib 2.3.0 >>>> upgrade to support Java 8 bytecode and a new baselining feature: >>>> >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>>> version=12324606&styleName=Html&projectId=12310100 >>>> >>>> There are still several outstanding issues which people can contribute >>>> towards fixing :) >>>> >>>> https://issues.apache.org/jira/issues/?jql=component+% >>>> 3D+%22Maven+Bundle+Plugin%22+AND+project+%3D+FELIX+AND+ >>>> resolution+%3D+Unresolved+ORDER+BY+priority+DESC >>>> >>>> Release source tag: >>>> >>>> https://svn.apache.org/repos/asf/felix/releases/maven- >>>> bundle-plugin-2.5.0/ >>>> >>>> Staging repository: >>>> >>>> https://repository.apache.org/content/repositories/ >>>> orgapachefelix-1024/ >>>> >>>> You can use this UNIX script to download the release and verify the >>>> signatures: >>>> >>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_ >>>> release.sh >>>> >>>> Usage: >>>> >>>> sh check_staged_release.sh 1024 /tmp/felix-staging >>>> >>>> Please vote to approve this release: >>>> >>>> [ ] +1 Approve the release >>>> [ ] -1 Veto the release (please provide specific comments) >>>> >>>> This vote will be open for 72 hours. >>>> >>>> — >>>> Cheers, Stuart >>>> >>>> >>> -- >>> Jean-Baptiste Onofré >>> jbono...@apache.org >>> http://blog.nanthrax.net >>> Talend - http://www.talend.com >>> >
