Thanks Pierre for reporting - you're actually doing everything correct - unfortunately there is a bug in the maven bundle plugin 2.5.1. So I'll cancel that vote.
Carsten 2014-08-23 23:08 GMT+02:00 Pierre De Rop <[email protected]>: > Hi Carsten; > > I may be wrong but I'm using a test project with some Apache scr > annotations + bundle-plugin 2.5.1 + scr-plugin 1.20.0 and after doing "mvn > clean install", it looks like the scr xml descriptors are not included in > my target bundle (but this test project seems to work correctly with > previous scr-plugin 1.17.0). > > During compilation, I can see that descriptors are generated in > target/classes/OSGI-INF/: > > [INFO] Writing 1 Service Component Descriptors to > > /home/nxuser/work/osgi/test/test.scr.plugin/target/classes/OSGI-INF/org.apache.felix.scrplugin.sample.DictionaryClient.xml > [INFO] Writing 1 Service Component Descriptors to > > /home/nxuser/work/osgi/test/test.scr.plugin/target/classes/OSGI-INF/org.apache.felix.scrplugin.sample.EventProducer.xml > [INFO] Writing 1 Service Component Descriptors to > > /home/nxuser/work/osgi/test/test.scr.plugin/target/classes/OSGI-INF/org.apache.felix.scrplugin.sample.EnglishDictionary.xml > > But once compilation is done, then the component descriptors are not > incuded in the target bundle: > > jar tvf target/org.apache.felix.scrplugin.sample-3.0.0-SNAPSHOT.jar > > 1868 Sat Aug 23 22:44:36 CEST 2014 META-INF/MANIFEST.MF > 0 Sat Aug 23 22:44:36 CEST 2014 META-INF/ > 0 Sat Aug 23 22:44:36 CEST 2014 META-INF/maven/ > 0 Sat Aug 23 22:44:36 CEST 2014 META-INF/maven/test/ > 0 Sat Aug 23 22:44:36 CEST 2014 > META-INF/maven/test/org.apache.felix.scrplugin.sample/ > 156 Sat Aug 23 22:44:36 CEST 2014 > META-INF/maven/test/org.apache.felix.scrplugin.sample/pom.properties > 1955 Sat Aug 23 22:44:28 CEST 2014 > META-INF/maven/test/org.apache.felix.scrplugin.sample/pom.xml > 0 Sat Aug 23 22:44:36 CEST 2014 org/ > 0 Sat Aug 23 22:44:36 CEST 2014 org/apache/ > 0 Sat Aug 23 22:44:36 CEST 2014 org/apache/felix/ > 0 Sat Aug 23 22:44:36 CEST 2014 org/apache/felix/scrplugin/ > 0 Sat Aug 23 22:44:36 CEST 2014 org/apache/felix/scrplugin/sample/ > 1598 Sat Aug 23 22:44:36 CEST 2014 > org/apache/felix/scrplugin/sample/DictionaryClient.class > 193 Sat Aug 23 22:44:34 CEST 2014 > org/apache/felix/scrplugin/sample/DictionaryService.class > 2241 Sat Aug 23 22:44:34 CEST 2014 > org/apache/felix/scrplugin/sample/EnglishDictionary.class > 1352 Sat Aug 23 22:44:34 CEST 2014 > org/apache/felix/scrplugin/sample/EventProducer$1.class > 1163 Sat Aug 23 22:44:36 CEST 2014 > org/apache/felix/scrplugin/sample/EventProducer.class > > Can you check if the following pom.xml is correct or if I have missed > something ? > thanks; > > <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi=" > http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > <modelVersion>4.0.0</modelVersion> > <packaging>bundle</packaging> > <groupId>test</groupId> > <artifactId>org.apache.felix.scrplugin.sample</artifactId> > <version>3.0.0-SNAPSHOT</version> > <name>Apache Felix SCR Plugin Samples</name> > > <dependencies> > <dependency> > <groupId>org.apache.felix</groupId> > <artifactId>org.apache.felix.eventadmin</artifactId> > <version>1.4.0</version> > </dependency> > > <dependency> > <groupId>org.apache.felix</groupId> > <artifactId>org.apache.felix.scr.annotations</artifactId> > <version>1.9.8</version> > </dependency> > </dependencies> > > <build> > <plugins> > <plugin> > <groupId>org.apache.maven.plugins</groupId> > <artifactId>maven-compiler-plugin</artifactId> > <configuration> > <source>1.7</source> > <target>1.7</target> > </configuration> > </plugin> > > <plugin> > <groupId>org.apache.felix</groupId> > <artifactId>maven-bundle-plugin</artifactId> > <version>2.5.1</version> > <extensions>true</extensions> > <configuration> > <instructions> > <Bundle-Name>Apache Felix SCR Plugin > Sample</Bundle-Name> > > > <Bundle-SymbolicName>org.apache.felix.scrplugin.samples</Bundle-SymbolicName> > <Import-Package>*</Import-Package> > > <Private-Package>org.apache.felix.scrplugin.sample</Private-Package> > </instructions> > </configuration> > </plugin> > > <plugin> > <groupId>org.apache.felix</groupId> > <artifactId>maven-scr-plugin</artifactId> > <version>1.20.0</version> > > <executions> > <execution> > <id>generate-scr-scrdescriptor</id> > <goals> > <goal>scr</goal> > </goals> > </execution> > </executions> > </plugin> > </plugins> > </build> > </project> > > > /Pierre > > > On Fri, Aug 22, 2014 at 10:38 AM, Carsten Ziegeler <[email protected]> > wrote: > > > +1 > > > > > > 2014-08-22 9:57 GMT+02:00 Jean-Baptiste Onofré <[email protected]>: > > > > > +1 (non binding) > > > > > > Regards > > > JB > > > > > > > > > On 08/22/2014 09:51 AM, David Bosschaert wrote: > > > > > >> +1 Approve the release > > >> > > >> David > > >> > > >> On 22 August 2014 07:51, Carsten Ziegeler <[email protected]> > wrote: > > >> > > >>> Hi, > > >>> > > >>> we fixed one issue in the Maven SCR Plugin: > > >>> https://issues.apache.org/jira/browse/FELIX-4595 > > >>> > > >>> > > >>> Staging repository: > > >>> > https://repository.apache.org/content/repositories/orgapachefelix-1034 > > >>> > > >>> You can use this UNIX script to download the release and verify the > > >>> signatures: > > >>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh > > >>> > > >>> Usage: > > >>> sh check_staged_release.sh 1034 /tmp/felix-staging > > >>> > > >>> > > >>> Please vote to approve this release: > > >>> > > >>> [ ] +1 Approve the release > > >>> [ ] 0 Don't care > > >>> [ ] -1 Don't release, because ... > > >>> > > >>> This vote will be open for 72 hours. > > >>> > > >>> Regards > > >>> Carsten > > >>> -- > > >>> Carsten Ziegeler > > >>> Adobe Research Switzerland > > >>> [email protected] > > >>> > > >> > > > -- > > > Jean-Baptiste Onofré > > > [email protected] > > > http://blog.nanthrax.net > > > Talend - http://www.talend.com > > > > > > > > > > > -- > > Carsten Ziegeler > > Adobe Research Switzerland > > [email protected] > > > -- Carsten Ziegeler Adobe Research Switzerland [email protected]
