[ 
https://issues.apache.org/jira/browse/FELIX-4686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207456#comment-14207456
 ] 

Carsten Ziegeler commented on FELIX-4686:
-----------------------------------------

[~djencks] Rethinking the whole story, for compatibility sake we should leave 
the switch (ds.factory.enabled) in.
So basically what you're saying is to always switch of ds.factory.enabled and 
change the old components that use that. However, you don't know which 
component is actually using this, right? If you have hundreds of bundles, you 
would need to rewrap all those bundles. (Or maybe I'm missing something).
Where on the other hand, we could simply say, if you're using the 1.3 NS, the 
ds.factory.enabled flag has no influence on your component anymore - which my 
patch does. And this simply ensures, old bundles work as is, new bundles work 
as expected as well.

> If component is declared with 1.3 NS and ds.factory.enabled = true, 
> validation error occors
> -------------------------------------------------------------------------------------------
>
>                 Key: FELIX-4686
>                 URL: https://issues.apache.org/jira/browse/FELIX-4686
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: scr-2.0.0
>
>
> For example the following component xml leads to a validation error:
> "Configuration of component factory instances through config admin factory 
> pids supported only through the 1.2 namespace"
> <components xmlns:scr="http://www.osgi.org/xmlns/scr/v1.3.0";>
>     <scr:component name="org.apache.sling.sample.slingshot.impl.SetupService" 
> activate="activate" deactivate="deactivate">
>         <implementation 
> class="org.apache.sling.sample.slingshot.impl.SetupService"/>
>         <property name="service.vendor" value="The Apache Software 
> Foundation"/>
>         <property name="service.pid" 
> value="org.apache.sling.sample.slingshot.impl.SetupService"/>
>     </scr:component>
> </components>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to