[ 
https://issues.apache.org/jira/browse/FELIX-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307051#comment-14307051
 ] 

Pierre De Rop commented on FELIX-4785:
--------------------------------------

Hello Carsten; 

Looking at the failing test (org.apache.felix.scr.integration.Felix3680Test), 
it looks like the
org.apache.felix.scr.integration.components.felix3680.Main class has now a 
"bindSCR" method that is now taking as parameter a 
org.osgi.service.component.runtime.ServiceComponentRuntime object.

However, at the end of the ./src/test/resources/integration_test_FELIX_3680.xml 
file, the descriptor for the "sCR" Reference still refers to the old API:

<code>
       ...
        <scr:component xmlns:scr='http://www.osgi.org/xmlns/scr/v1.1.0'
                
name='org.apache.felix.scr.integration.components.felix3680.Main'
                activate='start' deactivate='stop' enabled="false">
                <implementation
                        
class='org.apache.felix.scr.integration.components.felix3680.Main' />
                <reference name='a'
                        
interface='org.apache.felix.scr.integration.components.felix3680.A'
                        cardinality='0..n' bind='bindA' unbind='unbindA' 
policy='dynamic' />
                <reference name='logService' 
interface='org.osgi.service.log.LogService'
                        bind='bindLogService' />
                <reference name='sCR' 
interface='org.apache.felix.scr.ScrService'
                        bind='bindSCR' />
        </scr:component>
</code>

can you try to update the ./src/test/resources/integration_test_FELIX_3680.xml 
and change the "sCR" reference like this:

<code>
                ...
                <reference name='sCR' 
interface='org.osgi.service.component.runtime.ServiceComponentRuntime'
                        bind='bindSCR' />
</code>



> Incompatible SCR API
> --------------------
>
>                 Key: FELIX-4785
>                 URL: https://issues.apache.org/jira/browse/FELIX-4785
>             Project: Felix
>          Issue Type: Bug
>    Affects Versions: scr-2.0.0
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: scr-2.0.0
>
>
> Current trunk contains version 2.0.0 of the org.apache.felix.scr API package. 
> While this is a logical step, this makes the new implementation unusable as a 
> drop-in replacement into existing installations which might use the 1.x 
> version of that API.
> I think we should go a more moderate way, leave the 1.x version in but 
> deprecate it and also provide the replacement API (if any). Then in one of 
> the further versions along the road, we can remove the API. This gives our 
> users a chance to migrate slowly



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to