[ 
https://issues.apache.org/jira/browse/FELIX-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367208#comment-14367208
 ] 

J.W. Janssen commented on FELIX-4829:
-------------------------------------

there is a flaw in your proposed patch: if the log service goes away or is 
started later than Gogo, it won't be picked up by this command. I think you 
should use a ServiceTracker and ask for *all* of its services if you are in 
need of logging something. 

In addition, I think there are a couple of more places whether exceptions can 
occur (all commands that are invoked by Gogo?), shouldn't these be logged as 
well?


>  Gogo command error logging to available LogService
> ---------------------------------------------------
>
>                 Key: FELIX-4829
>                 URL: https://issues.apache.org/jira/browse/FELIX-4829
>             Project: Felix
>          Issue Type: Improvement
>          Components: Gogo Command
>            Reporter: Kamesh Sampath
>            Priority: Minor
>         Attachments: FELIX-4829.patch
>
>
> As Felix Gogo shell user I would like gogo commands to log the exceptions to 
> an available log service in addition to Sys.err, this enables the 
> LogListeners of the clients to capture and manipulate the log if required



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to