[
https://issues.apache.org/jira/browse/FELIX-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576775#comment-14576775
]
ASF GitHub Bot commented on FELIX-4848:
---------------------------------------
GitHub user cschneider opened a pull request:
https://github.com/apache/felix/pull/18
FELIX-4848 : Split ResolverImpl
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cschneider/felix FELIX-4848
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit e3024b0ffe74fb9e343ed4ae3224172223a92613
Author: Christian Schneider <[email protected]>
Date: 2015-06-02T14:22:43Z
FELIX-4848 : Split ResolverImpl
----
> Split ResolverImpl
> ------------------
>
> Key: FELIX-4848
> URL: https://issues.apache.org/jira/browse/FELIX-4848
> Project: Felix
> Issue Type: Improvement
> Components: Resolver
> Affects Versions: resolver-1.0.0
> Reporter: Christian Schneider
> Fix For: resolver-1.4.0
>
> Attachments: Dependencies in resolver package after patch.png,
> FELIX-4848-1.patch
>
>
> ResolverImpl currently contains about 2300 lines of code. That is way too big
> for a single class.
> I looked into it and found that the checkDynamicPackageSpaceConsistency and
> checkPackageSpaceConsistency methods and their dependent methods form a nice
> subset. I would move that into a class ConsistencyCheck.
> Both would share all of the inner classes of ResolverImpl but nothing else.
> So I think i would make sense to move these inner classes to separate files.
> These changes should nicely split the classes into
> ResolverImpl : 1400 lines
> ConsistencyCheck : 600 lines
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
