[ 
https://issues.apache.org/jira/browse/FELIX-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647601#comment-14647601
 ] 

ASF GitHub Bot commented on FELIX-4302:
---------------------------------------

GitHub user balazs-zsoldos opened a pull request:

    https://github.com/apache/felix/pull/32

    Escape pid segment names only when truly necessary

    FELIX-4302: Escape only folder names that are truly reserved.
    
    Fixing incompatibility issues that were raised by the solution of 
FELIX-4302.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/balazs-zsoldos/felix felix-4945

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/felix/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 2cfce76e6de5f18e91656ab58e63e40468f98146
Author: Balazs Zsoldos <[email protected]>
Date:   2015-07-30T13:07:49Z

    Escape pid segment names only when truly necessary

----


> Config Admin can create illegal names on windows
> ------------------------------------------------
>
>                 Key: FELIX-4302
>                 URL: https://issues.apache.org/jira/browse/FELIX-4302
>             Project: Felix
>          Issue Type: Bug
>          Components: Configuration Admin
>    Affects Versions: configadmin-1.8.0
>            Reporter: Peter Kriens
>            Assignee: Felix Meschberger
>             Fix For: configadmin-1.8.2
>
>
> The following names are not allowed to be used in a path on Windows:
> CON, PRN, AUX, CLOCK$, NUL, COM1 ... COM9, LPT1 ... LPT9.
> If the last part of the PID is one of these names then an exception results. 
> I guess adding an extension (.cfg) to this file would prevent this clash. 
> There might actually 
> java.io.IOException: Het systeem kan het opgegeven pad niet vinden
>     at java.io.WinNTFileSystem.createFileExclusively(Native Method)
>     at java.io.File.createNewFile(File.java:1006)
>     at java.io.File.createTempFile(File.java:1989)
>     at 
> org.apache.felix.cm.file.FilePersistenceManager._store(FilePersistenceManager.java:621)
>     at 
> org.apache.felix.cm.file.FilePersistenceManager.store(FilePersistenceManager.java:582)
>     at 
> org.apache.felix.cm.impl.CachingPersistenceManagerProxy.store(CachingPersistenceManagerProxy.java:173)
>     at 
> org.apache.felix.cm.impl.ConfigurationImpl.update(ConfigurationImpl.java:387)
>     at 
> org.apache.felix.cm.impl.ConfigurationAdapter.update(ConfigurationAdapter.java:131)
>     at aQute.impl.configurer.Configurer.configure(Configurer.java:147)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to