+1 (non-binding)
On Sat, Oct 3, 2015 at 2:59 AM, Carsten Ziegeler <[email protected]> wrote: > I assume this is due to a very old parent pom - or a misconfiguration in > that parent pom. Should really be easy to fix. > > Carsten > > Am 02.10.15 um 19:14 schrieb David Jencks: >> I’d vote for just moving to a gradle/bndtools build…. >> >> A little experimentation suggests that the maven-bundle-plugin 2.4.3 used in >> command can’t produce source jars whereas the 1.4.3 version used in shell >> can. the 2.4.3 version produces this output: >> >> [INFO] --- maven-source-plugin:2.0.4:jar (default-cli) @ >> org.apache.felix.gogo.command --- >> [WARNING] NOT adding sources to artifacts with classifier as Maven only >> supports one classifier per artifact. Current artifact >> [org.apache.felix:org.apache.felix.gogo.command:bundle:0.16.0] has a [] >> classifier. >> >> instead of making the requested jar. >> >> david jencks >> >>> On Oct 2, 2015, at 12:42 PM, Benson Margulies <[email protected]> wrote: >>> >>> I could take a look at this for the next iteration. >>> >>> >>> On Fri, Oct 2, 2015 at 12:41 PM, David Jencks >>> <[email protected]> wrote: >>>> Hi David, >>>> >>>> Well, I was sort of hoping you’d figure out a way to release the sources >>>> bundle too :-). However I can create my own for my needs. I’ve now >>>> tested the fixes I added and they seem to work, so, at long last, >>>> >>>> +1 >>>> >>>> thanks >>>> david jencks >>>> >>>> >>>>> On Oct 1, 2015, at 6:25 PM, [email protected] wrote: >>>>> >>>>> Hi David, >>>>> >>>>> I didn't change the build process for these artifacts, so I guess they >>>>> were released like this before. In any case, the important artifacts >>>>> are there. We can change the produced artifacts for a future release, >>>>> but I don't think this is important enough to cancel this one. >>>>> >>>>> BTW I can't count your email as a +1 or -1, so please indicate how you >>>>> actually vote here. >>>>> >>>>> Thanks, >>>>> >>>>> David >>>>> >>>>> On 1 October 2015 at 18:19, David Jencks <[email protected]> >>>>> wrote: >>>>>> sigs look good, I can build the project tar.gzs. >>>>>> >>>>>> The selection of artifacts looks a bit bizarre to me. I don’t see a >>>>>> sources bundle for org.apache.felix.gogo.command-0.16.0 and I can’t >>>>>> imagine what the bin artifacts are for. Is this all intentional? >>>>>> I’d really prefer there be a >>>>>> org.apache.felix.gogo.command-0.16.0-sources.jar >>>>>> >>>>>> thanks for undertaking this release :-) >>>>>> >>>>>> david jencks >>>>>> >>>>>>> On Oct 1, 2015, at 4:42 AM, [email protected] wrote: >>>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> I'm calling a vote on the following bundles: >>>>>>> >>>>>>> Felix Gogo Shell 0.12.0 >>>>>>> ** Improvement >>>>>>> * FELIX-5021 [GOGO] Use system bundle to find bundles >>>>>>> * FELIX-4529 [Gogo] Let gosh be configured by files contributed by >>>>>>> a bundle fragment >>>>>>> * FELIX-3341 Simple csh-like Command History >>>>>>> * FELIX-3340 Allow the prompt to be a Function >>>>>>> >>>>>>> ** Bug >>>>>>> * FELIX-4425 Short command in Gogo Shell not working with Java 8 >>>>>>> * FELIX-3706 gogo shell startup failure in busy system >>>>>>> * FELIX-3703 Race condition in gogo runtime activator >>>>>>> >>>>>>> Felix Gogo Command 0.16.0 >>>>>>> ** Improvement >>>>>>> * FELIX-5021 [GOGO] Use system bundle to find bundles >>>>>>> * FELIX-5009 Relative URIs would be nice for install and update >>>>>>> * FELIX-5008 gogo usage messages could be less confusing >>>>>>> * FELIX-3499 felix:cd command works only with relative paths >>>>>>> >>>>>>> ** Bug >>>>>>> * FELIX-4969 cd refuses to leave initial directory >>>>>>> >>>>>>> Note that not changes have been made to the Felix Gogo Runtime bundle >>>>>>> since the last release. >>>>>>> >>>>>>> Staging repository: >>>>>>> https://repository.apache.org/content/repositories/orgapachefelix-1096 >>>>>>> >>>>>>> You can use this UNIX script to download the release and verify the >>>>>>> signatures: >>>>>>> http://svn.apache.org/repos/asf/felix/trunk/check_staged_release.sh >>>>>>> >>>>>>> Usage: >>>>>>> sh check_staged_release.sh 1096 /tmp/felix-gogo-check >>>>>>> >>>>>>> Please vote to approve this release: >>>>>>> >>>>>>> [ ] +1 Approve the release >>>>>>> [ ] -1 Veto the release (please provide specific comments) >>>>>>> >>>>>>> This vote will remain open for at least 72 hours. >>>>>>> >>>>>>> Best regards, >>>>>>> >>>>>>> David Bosschaert >>>>>> >>>> >> >> > > > -- > Carsten Ziegeler > Adobe Research Switzerland > [email protected]
