If the default mode is the same as before, this should keep compatibility.
I don't have any problem adding a flag to disable directory processing, and
the proposed solution looks good to me (jar | recurse | skip).
The way to go would be to create a JIRA (actually, I think one already
exists for that) and attach a patch or provide a github pull request.

2015-12-11 9:05 GMT+01:00 Fabian Lange <[email protected]>:

> Hia,
> as an Apache Karaf user I was today surprised to see fileinstalls behaviour
> in a Profiler
>
> I am using the feature to provide multiple directories.
> I am using karaf/etc,karaf/etc/mystuff
>
> What I did learn is that "mystuff" is already scanned but treated as jar
> file. Sadly thats a big performance hog with a small update interval,
> because it creates temp files and copies the whole directory into it.
> I have actually not figured out how I would use that feature to be honest.
>
> What I however propose to do is to add a
>
> felix.fileinstall.subdirectory.mode = jar | recurese | skip
> Would this break any current functionality? when set to recurse or skip?
>
> How would be the process to integrate my changes? I could provide a diff.
>
> And if somebody minds, please tell me how that jar thing is supposed to
> work :)
>
> Best regards,
> Fabian
>
> --
> Fabian Lange | Performance Expert
> mobil: +49 (0) 160.3673393
>
> codecentric AG | Merscheider Straße 1 | 42699 Solingen | Deutschland
>
> Sitz der Gesellschaft: Solingen | HRB 25917| Amtsgericht Wuppertal
> Vorstand: Michael Hochgürtel . Mirko Novakovic . Rainer Vehns
> Aufsichtsrat: Patric Fedlmeier (Vorsitzender) . Klaus Jäger . Jürgen Schütz
>

Reply via email to