[
https://issues.apache.org/jira/browse/FELIX-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106526#comment-15106526
]
ASF GitHub Bot commented on FELIX-1184:
---------------------------------------
Github user gdelafosse commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/186#issuecomment-172799284
You should enjoy this update :
- I simplify the gremlin-shaded pom thanks to the solution explained
[here](https://issues.apache.org/jira/browse/FELIX-1184)
The idea is to call sequentially the maven-shade-plugin to shade the
dependencies, the maven-jar-plugin to unpack the shaded jar, and eventually the
maven-bundle-plugin to compute the OSGI MANIFEST entries and repack the jar.
- I implemented an integration test to test that germlin-core is a valid
OSGI bundle.
Unfortunately I don't manage to implement the same test for
tinkerpop-gremlin because when I add my test dependencies it breaks the
existing test (hamcrest Matchers classes are not found). I don't understand for
the moment how the tinkerpop-gremlin tests work...
> maven-bundle-plugin does not play well with maven-shade-plugin relocate
> -----------------------------------------------------------------------
>
> Key: FELIX-1184
> URL: https://issues.apache.org/jira/browse/FELIX-1184
> Project: Felix
> Issue Type: Bug
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.0.0
> Reporter: David Jencks
> Assignee: Stuart McCulloch
>
> maven-shade-plugin v 1.2.1
> If your build runs shade to relocate some classes from a preexisting jar and
> the maven-bundle-plugin to geinerate osgi metadata the bundle plugin refuses
> to generate any Export-Package, Import-Package or Private-Package headers. I
> assume it doesn't find any classes.
> I don't know whose fault this is.
> To see this in action check out
> https://svn.apache.org/repos/asf/geronimo/xbean/trunk/xbean-asm-shaded rev
> 778992 and uncomment the bundle plugin and comment the transformers section
> of the shade plugin config.
> This is also reported as http://jira.codehaus.org/browse/MSHADE-51
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
