[
https://issues.apache.org/jira/browse/FELIX-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194975#comment-15194975
]
Konrad Windszus commented on FELIX-4009:
----------------------------------------
Regarding
{quote}
i'm still not shure when this m2e-tycho plugin gets installed. konrad described
when this is happening here:
https://github.com/apache/felix/pull/57#issuecomment-195718014
i've never used this catalog, but perhaps others are affected. the answer in
http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05444.html is:
"Anders Hammar: As I understand the plugin has priority. The connector will be
ignored.".
so there is no conflict?
{quote}
The answer from Anders Hammar is not correct. The right answer is from Anton
Tanasenko in http://dev.eclipse.org/mhonarc/lists/m2e-users/msg05446.html.
Basically m2e-tycho will always be preferred if it is installed. Since we
cannot do anything about this, there should at least be a big hint in the
documentation about that.
{quote} 2. it does only cover goal manifest but not bundle {quote}
I do understand that the actual packaging should not be done during the
incremental build. But still usually noone explicitly configured the goal
{{manifest}} for packaging {{bundle}}. Therefore the m2e does not help here at
all. m2e-tycho basically treats both goals in the same fashion
(https://github.com/tesla/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/felix/internal/MavenBundlePluginConfigurator.java#L58).
Maybe you could do the same. I am just not sure, how to detect, whether the
goal is executed as part of the normal Maven build or triggered from m2e.
> maven bundle plugin should be integrated directly with eclipse
> --------------------------------------------------------------
>
> Key: FELIX-4009
> URL: https://issues.apache.org/jira/browse/FELIX-4009
> Project: Felix
> Issue Type: New Feature
> Components: Maven Bundle Plugin
> Affects Versions: maven-bundle-plugin-2.3.7
> Reporter: Andrei Pozolotin
> Assignee: Carsten Ziegeler
> Labels: m2e
> Fix For: maven-bundle-plugin-3.0.2
>
>
> Stuart:
> 1) currently, to integrate maven-bundle-plugin into m2e, one must use tycho
> configurator
> https://github.com/sonatype/m2eclipse-tycho
> which adds needles complexity, and makes few strange assumptions
> https://github.com/sonatype/m2eclipse-tycho/blob/master/org.sonatype.tycho.m2e/src/org/sonatype/tycho/m2e/internal/OsgiBundleProjectConfigurator.java#L74
> which no one it seems is there to care to correct
> https://github.com/sonatype/m2eclipse-tycho/pull/8
> 2) instead, I suggest maven-bundle-plugin to provide direct integration with
> eclipse via
> http://wiki.eclipse.org/M2E_compatible_maven_plugins#BuildContext
> which I would expect to be more customizable / flexible for the end user.
> I recently made similar switch with my DS plugin, and life got easier :-)
> https://github.com/carrot-garden/carrot-maven/tree/master/carrot-maven-scr-plugin
> thanks.
> Andrei.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
