2016-03-21 19:56 GMT+01:00 David Jencks <[email protected]>:

> So have you made gogo trunk java 8 only?
>
> I’m rather unhappy that there don’t appear to be any jira items explaining
> this work.
>

Yeah, again, I thought this has been somewhat discussed months ago on the
dev list.
I'd be happy to revert and restart the discussion from scratch if you want.


>
> thanks
> david jencks
>
> > On Mar 21, 2016, at 11:38 AM, Guillaume Nodet <[email protected]> wrote:
> >
> > All those commits are basically related to two things that have been
> > partially covered in this thread:
> >  http://www.mail-archive.com/users%40felix.apache.org/msg16883.html
> > Given nobody reacted or opposed to the work, I decided to commit it.
> > Though I now realised it was on user@ and not @dev
> >
> > It basically comes down to:
> >  * a jline based shell
> >  * enhancements to the gogo runtime to provide better parsing, job
> > control, redirections, parameter expansion
> >
> > Cheers,
> > Guillaume Nodet
> >
> >
> >
> > 2016-03-21 19:02 GMT+01:00 David Jencks <[email protected]
> >:
> >
> >> Are there jira work items covering this really long sequence of commits?
> >> I really like some pointer to a description of what’s going on with
> commits.
> >>
> >> thanks
> >> david jencks
> >>
> >>> On Mar 21, 2016, at 10:00 AM, [email protected] wrote:
> >>>
> >>> Author: gnodet
> >>> Date: Mon Mar 21 17:00:11 2016
> >>> New Revision: 1736059
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1736059&view=rev
> >>> Log:
> >>> Remove dependency on SSH
> >>>
> >>> Modified:
> >>>
> >>
> felix/trunk/gogo/jline/src/main/java/org/apache/felix/gogo/jline/Posix.java
> >>>
> >>> Modified:
> >>
> felix/trunk/gogo/jline/src/main/java/org/apache/felix/gogo/jline/Posix.java
> >>> URL:
> >>
> http://svn.apache.org/viewvc/felix/trunk/gogo/jline/src/main/java/org/apache/felix/gogo/jline/Posix.java?rev=1736059&r1=1736058&r2=1736059&view=diff
> >>>
> >>
> ==============================================================================
> >>> ---
> >>
> felix/trunk/gogo/jline/src/main/java/org/apache/felix/gogo/jline/Posix.java
> >> (original)
> >>> +++
> >>
> felix/trunk/gogo/jline/src/main/java/org/apache/felix/gogo/jline/Posix.java
> >> Mon Mar 21 17:00:11 2016
> >>> @@ -75,7 +75,6 @@ import org.apache.felix.gogo.api.Process
> >>> import org.apache.felix.gogo.jline.Shell.Context;
> >>> import org.apache.felix.service.command.CommandProcessor;
> >>> import org.apache.felix.service.command.CommandSession;
> >>> -import org.apache.sshd.common.util.OsUtils;
> >>> import org.jline.builtins.Commands;
> >>> import org.jline.builtins.Less;
> >>> import org.jline.builtins.Nano;
> >>> @@ -89,6 +88,7 @@ import org.jline.utils.AttributedString;
> >>> import org.jline.utils.AttributedStringBuilder;
> >>> import org.jline.utils.AttributedStyle;
> >>> import org.jline.utils.InfoCmp.Capability;
> >>> +import org.jline.utils.OSUtils;
> >>>
> >>> /**
> >>> * Posix-like utilities.
> >>> @@ -1924,7 +1924,7 @@ public class Posix {
> >>>            perms.add(PosixFilePermission.OTHERS_WRITE);
> >>>        }
> >>>
> >>> -        if (f.canExecute() || (OsUtils.isWin32() &&
> >> isWindowsExecutable(f.getName()))) {
> >>> +        if (f.canExecute() || (OSUtils.IS_WINDOWS &&
> >> isWindowsExecutable(f.getName()))) {
> >>>            perms.add(PosixFilePermission.OWNER_EXECUTE);
> >>>            perms.add(PosixFilePermission.GROUP_EXECUTE);
> >>>            perms.add(PosixFilePermission.OTHERS_EXECUTE);
> >>>
> >>>
> >>
> >>
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> > ------------------------
> > Red Hat, Open Source Integration
> >
> > Email: [email protected]
> > Web: http://fusesource.com
> > Blog: http://gnodet.blogspot.com/
>
>


-- 
------------------------
Guillaume Nodet
------------------------
Red Hat, Open Source Integration

Email: [email protected]
Web: http://fusesource.com
Blog: http://gnodet.blogspot.com/

Reply via email to