[jira] [Commented] (FELIX-5261) FileInstall: allow comments in *.config files

[Ferry Huberts (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FELIX-5261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420890#comment-15420890
 ] 

Ferry Huberts commented on FELIX-5261:
--------------------------------------

I did see 2 changes in imported packages:
{code}
     <requirement namespace="osgi.wiring.package">
-      <directive name="filter" 
value="(&amp;(osgi.wiring.package=org.osgi.service.cm)(version&gt;=1.3.0)(!(version&gt;=2.0.0)))"/>
+      <directive name="filter" 
value="(&amp;(osgi.wiring.package=org.osgi.service.cm)(version&gt;=1.5.0)(!(version&gt;=2.0.0)))"/>
       <directive name="resolution" value="optional"/>
     </requirement>
     <requirement namespace="osgi.wiring.package">
-      <directive name="filter" 
value="(&amp;(osgi.wiring.package=org.osgi.util.tracker)(version&gt;=1.4.0)(!(version&gt;=2.0.0)))"/>
+      <directive name="filter" 
value="(&amp;(osgi.wiring.package=org.osgi.util.tracker)(version&gt;=1.5.0)(!(version&gt;=2.0.0)))"/>
     </requirement>
{code}

> FileInstall: allow comments in *.config files
> ---------------------------------------------
>
>                 Key: FELIX-5261
>                 URL: https://issues.apache.org/jira/browse/FELIX-5261
>             Project: Felix
>          Issue Type: Improvement
>          Components: File Install
>    Affects Versions: fileinstall-3.5.4
>         Environment: All
>            Reporter: Ferry Huberts
>            Assignee: Guillaume Nodet
>             Fix For: fileinstall-3.5.6
>
>
> Previous updates to ConfigAdmin forgot to update FileInstall.
> FileInstall only uses a single class from ConfigAdmin, but upgrading that 
> dependency to the latest ConfigAdmin enables comments in *.config files.
> This enables me to get rid of all the *.config.txt files in my project (that 
> are used to document for users what options are available)
> I have already summitted a PR on GitHub: 
> https://github.com/apache/felix/pull/67



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)